fix domain boundary in build_after — eliminate reload workaround

relate_instance functions now pass %Instance{id: result.id} to Provider
calls rather than converting the domain-specific struct via Map.from_struct.
This respects Ash's static relationship contracts (Feature.instance_id
belongs to Diffo.Provider.Instance, not Shelf or Card).

build_after/2 ends with Ash.load/2 to load relationships back onto the
correct domain struct, replacing the per-domain reload that was masking
the struct type loss. build_after/4 removed entirely.

Also replaces Map.put with struct update syntax and drops dead-looking
aliases in favour of fully qualified module names in DSL options.

Author: matt-beanland

lib/diffo/provider/components/base_instance.ex

@@ -69,7 +69,7 @@ defmodule Diffo.Provider.BaseInstance do
 
       create :build do
         change after_action(fn changeset, result, _context ->
-          ActionHelper.build_after(changeset, result, MyApp.Domain, :get_cluster_by_id)
+          ActionHelper.build_after(changeset, result)
         end)
       end
   """

lib/diffo/provider/components/instance/extension/action_helper.ex

@@ -25,14 +25,16 @@ defmodule Diffo.Provider.Instance.ActionHelper do
   @doc """
   build after_action helper, relates TMF entities to the new instance
   """
-  def build_after(changeset, result, module, function) do
-    with {:ok, result} <- Specification.relate_instance(result, changeset),
-         {:ok, result} <- Relationship.relate_instance(result, changeset),
-         {:ok, result} <- Feature.relate_instance(result, changeset),
-         {:ok, result} <- Characteristic.relate_instance(result, changeset),
-         {:ok, result} <- Place.relate_instance(result, changeset),
-         {:ok, result} <- Party.relate_instance(result, changeset),
-         {:ok, result} <- apply(module, function, [result.id]),
-         do: {:ok, result}
+  def build_after(changeset, result) do
+    specified_by = Ash.Changeset.get_argument(changeset, :specified_by)
+    result = %{result | specification_id: specified_by}
+
+    with {:ok, _} <- Specification.relate_instance(result, changeset),
+         {:ok, _} <- Relationship.relate_instance(result, changeset),
+         {:ok, _} <- Feature.relate_instance(result, changeset),
+         {:ok, _} <- Characteristic.relate_instance(result, changeset),
+         {:ok, _} <- Place.relate_instance(result, changeset),
+         {:ok, _} <- Party.relate_instance(result, changeset),
+         do: Ash.load(result, [:specification, :characteristics, :features, :parties])
   end
 end

lib/diffo/provider/components/instance/extension/characteristic.ex

@@ -73,8 +73,7 @@ defmodule Diffo.Provider.Instance.Characteristic do
   def relate_instance(result, changeset)
       when is_struct(result) and is_struct(changeset, Ash.Changeset) do
     characteristics = Ash.Changeset.get_argument(changeset, :characteristics)
-    instance = struct(Instance, Map.from_struct(result))
-    Provider.relate_instance_characteristics(instance, %{characteristics: characteristics})
+    Provider.relate_instance_characteristics(%Instance{id: result.id}, %{characteristics: characteristics})
   end
 
   @doc """

lib/diffo/provider/components/instance/extension/feature.ex

@@ -101,8 +101,7 @@ defmodule Diffo.Provider.Instance.Feature do
   def relate_instance(result, changeset)
       when is_struct(result) and is_struct(changeset, Ash.Changeset) do
     features = Ash.Changeset.get_argument(changeset, :features)
-    instance = struct(Instance, Map.from_struct(result))
-    Provider.relate_instance_features(instance, %{features: features})
+    Provider.relate_instance_features(%Instance{id: result.id}, %{features: features})
   end
 
   defimpl String.Chars do

lib/diffo/provider/components/instance/extension/specification.ex

@@ -52,18 +52,7 @@ defmodule Diffo.Provider.Instance.Specification do
   def relate_instance(result, changeset)
       when is_struct(result) and is_struct(changeset, Ash.Changeset) do
     specified_by = Ash.Changeset.get_argument(changeset, :specified_by)
-    instance = struct(Instance, Map.from_struct(result))
-
-    case Provider.specify_instance(instance, %{specified_by: specified_by}) do
-      {:ok, specification} ->
-        {:ok,
-         result
-         |> Map.put(:specification, specification)
-         |> Map.put(:specification_id, specified_by)}
-
-      {:error, error} ->
-        {:error, error}
-    end
+    Provider.specify_instance(%Instance{id: result.id}, %{specified_by: specified_by})
   end
 
   defimpl String.Chars do

test/support/resource/card.ex

@@ -58,7 +58,7 @@ defmodule Diffo.Test.Card do
              end)
 
       change after_action(fn changeset, result, _context ->
-               ActionHelper.build_after(changeset, result, Servo, :get_card_by_id)
+               ActionHelper.build_after(changeset, result)
              end)
 
       change load [:href]

test/support/resource/invalid/invalid_characteristic.ex

@@ -12,11 +12,9 @@ defmodule Diffo.Test.InvalidCharacteristic do
   alias Diffo.Provider.BaseInstance
   alias Diffo.Provider.Instance.ActionHelper
 
-  alias Diffo.Test.Servo
-
   use Ash.Resource,
     fragments: [BaseInstance],
-    domain: Servo
+    domain: Diffo.Test.Servo
 
   resource do
     description "Ash Resource with an invalid characteristic"
@@ -51,12 +49,7 @@ defmodule Diffo.Test.InvalidCharacteristic do
              end)
 
       change after_action(fn changeset, result, _context ->
-               ActionHelper.build_after(
-                 changeset,
-                 result,
-                 Servo,
-                 :get_invalid_characteristic_by_id
-               )
+               ActionHelper.build_after(changeset, result)
              end)
 
       change load [:href]

test/support/resource/invalid/invalid_feature_characteristic.ex

@@ -12,11 +12,9 @@ defmodule Diffo.Test.InvalidFeatureCharacteristic do
   alias Diffo.Provider.BaseInstance
   alias Diffo.Provider.Instance.ActionHelper
 
-  alias Diffo.Test.Servo
-
   use Ash.Resource,
     fragments: [BaseInstance],
-    domain: Servo
+    domain: Diffo.Test.Servo
 
   resource do
     description "Ash Resource with an invalid feature characteristic"
@@ -54,12 +52,7 @@ defmodule Diffo.Test.InvalidFeatureCharacteristic do
              end)
 
       change after_action(fn changeset, result, _context ->
-               ActionHelper.build_after(
-                 changeset,
-                 result,
-                 Servo,
-                 :get_invalid_feature_characteristic_by_id
-               )
+               ActionHelper.build_after(changeset, result)
              end)
 
       change load [:href]

test/support/resource/invalid/invalid_specification.ex

@@ -12,11 +12,9 @@ defmodule Diffo.Test.InvalidSpecification do
   alias Diffo.Provider.BaseInstance
   alias Diffo.Provider.Instance.ActionHelper
 
-  alias Diffo.Test.Servo
-
   use Ash.Resource,
     fragments: [BaseInstance],
-    domain: Servo
+    domain: Diffo.Test.Servo
 
   resource do
     description "Ash Resource with an invalid specification"
@@ -47,12 +45,7 @@ defmodule Diffo.Test.InvalidSpecification do
              end)
 
       change after_action(fn changeset, result, _context ->
-               ActionHelper.build_after(
-                 changeset,
-                 result,
-                 Servo,
-                 :get_invalid_specification_by_id
-               )
+               ActionHelper.build_after(changeset, result)
              end)
 
       change load [:href]

test/support/resource/shelf.ex

@@ -78,7 +78,7 @@ defmodule Diffo.Test.Shelf do
              end)
 
       change after_action(fn changeset, result, _context ->
-               ActionHelper.build_after(changeset, result, Servo, :get_shelf_by_id)
+               ActionHelper.build_after(changeset, result)
              end)
 
       change load [:href]