Merge pull request #108 from diffo-dev/106-resolve-test-resource-spark-warnings-on-compilation

removed duplicate tests

Author: matt-beanland

test/instance_extension/characteristic_test.exs

@@ -5,7 +5,6 @@
 defmodule Diffo.InstanceExtension.CharacteristicTest do
   @moduledoc false
   use ExUnit.Case
-  alias Diffo.Test.Servo
   alias Diffo.Test.Parties
 
   setup_all do
@@ -19,14 +18,6 @@ defmodule Diffo.InstanceExtension.CharacteristicTest do
   end
 
   describe "characteristic" do
-    test "create resource fails when characteristic value type invalid" do
-      {:error, error} = Servo.build_invalid_characteristic(%{})
-      %Ash.Error.Invalid{errors: errors} = error
-
-      assert hd(errors).message ==
-               "couldn't create characteristic with value of unknown type Elixir.InvalidValue"
-    end
-
     test "create resource with array characteristic - success" do
       {:ok, shelf} = Parties.build_shelf_with_installer()
 

test/instance_extension/feature_test.exs

@@ -5,7 +5,6 @@
 defmodule Diffo.InstanceExtension.FeatureTest do
   @moduledoc false
   use ExUnit.Case
-  alias Diffo.Test.Servo
   alias Diffo.Test.Parties
 
   setup_all do
@@ -19,19 +18,13 @@ defmodule Diffo.InstanceExtension.FeatureTest do
   end
 
   describe "feature" do
-    test "create resource with fails when feature characteristic value type invalid" do
-      {:error, error} = Servo.build_invalid_feature_characteristic(%{})
-      %Ash.Error.Invalid{errors: errors} = error
-
-      assert hd(errors).message ==
-               "couldn't create feature characteristic with value of unknown type Elixir.InvalidValue"
-    end
-
     test "create resource with array feature characteristic - success" do
       {:ok, shelf} = Parties.build_shelf_with_installer()
 
       spectral = Enum.find(shelf.features, fn f -> f.name == :spectralManagement end)
-      deployment_classes = Enum.find(spectral.characteristics, fn c -> c.name == :deploymentClasses end)
+
+      deployment_classes =
+        Enum.find(spectral.characteristics, fn c -> c.name == :deploymentClasses end)
 
       assert deployment_classes.is_array == true
       assert deployment_classes.values == []

test/instance_extension/specification_test.exs

@@ -19,12 +19,6 @@ defmodule Diffo.InstanceExtension.SpecificationTest do
   end
 
   describe "specification" do
-    test "create resource fails when specification id not uuid v4" do
-      {:error, error} = Servo.build_invalid_specification(%{})
-      %Ash.Error.Invalid{errors: errors} = error
-      assert hd(errors).message == "must be a uuid v4 or nil"
-    end
-
     test "description declared in specification DSL roundtrips to the persisted specification" do
       spec_id = Shelf.specification()[:id]
       description = Shelf.specification()[:description]

test/support/resource/invalid/invalid_characteristic.ex

@@ -16,9 +16,6 @@ defmodule Diffo.Test.Servo do
   alias Diffo.Test.Card
   alias Diffo.Test.Broadband
   alias Diffo.Test.BroadbandV2
-  alias Diffo.Test.InvalidSpecification
-  alias Diffo.Test.InvalidCharacteristic
-  alias Diffo.Test.InvalidFeatureCharacteristic
 
   domain do
     description "service and resource management"
@@ -50,20 +47,5 @@ defmodule Diffo.Test.Servo do
       define :build_broadband_v2, action: :build
       define :get_broadband_v2_by_id, action: :read, get_by: :id
     end
-
-    resource InvalidSpecification do
-      define :get_invalid_specification_by_id, action: :read, get_by: :id
-      define :build_invalid_specification, action: :build
-    end
-
-    resource InvalidCharacteristic do
-      define :get_invalid_characteristic_by_id, action: :read, get_by: :id
-      define :build_invalid_characteristic, action: :build
-    end
-
-    resource InvalidFeatureCharacteristic do
-      define :get_invalid_feature_characteristic_by_id, action: :read, get_by: :id
-      define :build_invalid_feature_characteristic, action: :build
-    end
   end
 end