Missing the `Person::all()` to list persons

[rayrutjes]

The PHP API client is missing the \Delighted\Person::all(); method.

Also, it would be nice to be able to expand the properties value.
Current this value is not returned as part of the GET /people endpoint, which makes it hard to partially update some properties from different non connected systems.

[mkdynamic]

The PHP API client is missing the \Delighted\Person::all(); method.

@rayrutjes Thanks for this suggestion, we definitely need to add this method.

Also, it would be nice to be able to expand the properties value.
Currently this value is not returned as part of the GET /people endpoint, which makes it hard to partially update some properties from different non connected systems.

The properties are associated with a specific survey (vs. the person) and so we only return properties as part of survey payloads (vs. person payloads). You should be able to get properties using \Delighted\SurveyResponse::all(['person_id' => '123']) and \Delighted\SurveyResponse::retrieve(). Hopefully that helps.

[rayrutjes]

Thanks for your answer @mkdynamic

The properties are associated with a specific survey (vs. the person) and so we only return properties as part of survey payloads (vs. person payloads)

Indeed, I understand this now. This was non trivial to understand from documentation.

You should be able to get properties using \Delighted\SurveyResponse::all(['person_id' => '123']) and \Delighted\SurveyResponse::retrieve()

Unfortunately these requests only return responses, but there is no way to retrieve scheduled SurveyRequest's.

[mkdynamic]

Gotcha, makes sense. Yes, unfortunately we don't have any endpoints for listing SurveyRequests currently, but it's something we do plan to add. No timeline on that yet though.

[anil3a]

I have create a new pull request #19 .
This will add Person:all() feature, however keep in mind that this will return all active people from Delighted.