refactor: remove inline pointer functions from test files

Author: jsbroks

apps/workspace-engine/pkg/jobagents/testrunner/testrunner_test.go

@@ -83,9 +83,6 @@ func newTestJob(id string, config map[string]any) *oapi.Job {
 	}
 }
 
-//go:fix inline
-func ptr[T any](v T) *T { return new(v) }
-
 // ---------- Type() ----------
 
 func TestType(t *testing.T) {

apps/workspace-engine/pkg/workspace/releasemanager/policy/evaluator/deploymentwindow/deploymentwindow_test.go

@@ -21,16 +21,6 @@ func (m *mockGetters) HasCurrentRelease(_ context.Context, _ *oapi.ReleaseTarget
 	return m.hasRelease, m.err
 }
 
-//go:fix inline
-func boolPtr(b bool) *bool {
-	return new(b)
-}
-
-//go:fix inline
-func stringPtr(s string) *string {
-	return new(s)
-}
-
 func newTestScope() (context.Context, evaluator.EvaluatorScope) {
 	return context.Background(), evaluator.EvaluatorScope{
 		Environment: &oapi.Environment{Id: "env-1"},

apps/workspace-engine/pkg/workspace/releasemanager/policy/evaluator/gradualrollout/gradualrollout_test.go

@@ -164,12 +164,6 @@ func (m *mockGetters) GetJobsForEnvironmentAndVersion(
 // Test helpers
 // ---------------------------------------------------------------------------
 
-//go:fix inline
-func boolPtr(b bool) *bool { return new(b) }
-
-//go:fix inline
-func stringPtr(s string) *string { return new(s) }
-
 func makeResources(n int) ([]*oapi.Resource, map[string]*oapi.Resource) {
 	resources := make([]*oapi.Resource, n)
 	resourceMap := make(map[string]*oapi.Resource, n)

apps/workspace-engine/svc/controllers/jobdispatch/verification/template_test.go

@@ -8,9 +8,6 @@ import (
 	"workspace-engine/pkg/oapi"
 )
 
-//go:fix inline
-func ptr[T any](v T) *T { return new(v) }
-
 func makeDispatchContext(resource, environment string) *oapi.DispatchContext {
 	return &oapi.DispatchContext{
 		Resource:    &oapi.Resource{Name: resource},

apps/workspace-engine/svc/controllers/jobverificationmetric/metrics/provider/prometheus/prometheus_test.go

@@ -12,9 +12,6 @@ import (
 	"workspace-engine/svc/controllers/jobverificationmetric/metrics/provider"
 )
 
-//go:fix inline
-func ptr[T any](v T) *T { return new(v) }
-
 func TestNewPrometheusProvider(t *testing.T) {
 	tests := []struct {
 		name      string

apps/workspace-engine/svc/http/server/openapi/workflows/workflows_test.go

@@ -38,9 +38,6 @@ func booleanInput(key string, def *bool) oapi.WorkflowInput {
 	return input
 }
 
-//go:fix inline
-func ptr[T any](v T) *T { return new(v) }
-
 func TestResolveInputs_ProvidedInputsPassThrough(t *testing.T) {
 	workflow := &oapi.Workflow{
 		Inputs: []oapi.WorkflowInput{