Rename missed VCv2 folders to match convention.#117
Closed
BigBlueHat wants to merge 1 commit into
Closed
Conversation
Deploying vc-examples with
|
| Latest commit: |
c48b202
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fe9c7812.vc-examples.pages.dev |
| Branch Preview URL: | https://fix-vc-v2-folder-names.vc-examples.pages.dev |
bparth24
requested changes
Jan 13, 2026
Contributor
bparth24
left a comment
bparth24
left a comment
There was a problem hiding this comment.
@BigBlueHat changes looks good to me. However, PR shows there is one conflict which needs to be resolved before merging.
Contributor
|
Please consider my comments in the related issue: #116 (comment) |
Contributor
Author
|
Shipping this is probably not worth the trouble and we should take a more flexible approach to how we work with these examples in external projects. So, closing this as wontfix (at least not this way). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #116.