From e8a76ac43cc11e226e9c4708b7b37211938db216 Mon Sep 17 00:00:00 2001
From: Saverio Trioni <476895+rewritten@users.noreply.github.com>
Date: Thu, 26 Mar 2026 13:17:59 +0100
Subject: [PATCH 1/2] fix: handle missing category translations gracefully
 (fixes #829)

Add display_name to Category that falls back to any available translation
when the current locale's name is nil or blank, appending [locale] to
indicate the language it came from. Fixes crash in all_categories sort
when a category is created without a translation for the current locale.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 app/helpers/categories_helper.rb            | 2 +-
 app/models/category.rb                      | 9 ++++++++-
 app/views/shared/_post_filters.html.erb     | 4 ++--
 app/views/shared/_show_filter_hint.html.erb | 2 +-
 4 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/app/helpers/categories_helper.rb b/app/helpers/categories_helper.rb
index f644257b8..ee6c29ec5 100644
--- a/app/helpers/categories_helper.rb
+++ b/app/helpers/categories_helper.rb
@@ -1,6 +1,6 @@
 module CategoriesHelper
   def all_categories
-    @all_categories ||= Category.all.sort_by { |a| a.name.downcase }
+    @all_categories ||= Category.all.sort_by { |a| a.to_s.downcase }
   end
 
   def categories_for_select
diff --git a/app/models/category.rb b/app/models/category.rb
index 16b4e6063..1adb578b8 100644
--- a/app/models/category.rb
+++ b/app/models/category.rb
@@ -3,7 +3,14 @@ class Category < ApplicationRecord
 
   translates :name
 
+  def display_name
+    return name if name.present?
+
+    fallback_locale, fallback_name = name_translations&.find { |_, v| v.present? }
+    "#{fallback_name} [#{fallback_locale}]" if fallback_name
+  end
+
   def to_s
-    name
+    display_name
   end
 end
diff --git a/app/views/shared/_post_filters.html.erb b/app/views/shared/_post_filters.html.erb
index d471cb0c8..fa87f9dee 100644
--- a/app/views/shared/_post_filters.html.erb
+++ b/app/views/shared/_post_filters.html.erb
@@ -19,7 +19,7 @@
     <ul class="nav navbar-nav d-none d-sm-flex">
       <li class="dropdown nav-item">
         <a class="dropdown-toggle nav-link text-primary" href="#" data-bs-toggle="dropdown" role="button" aria-expanded="false">
-          <%= @category ? @category.name : Category.model_name.human %>
+          <%= @category ? @category.display_name : Category.model_name.human %>
         </a>
         <ul class="dropdown-menu" role="menu">
           <li>
@@ -30,7 +30,7 @@
             <li>
               <%= link_to "#{base_path}?cat=#{c.id}", class: "dropdown-item" do %>
                 <%= category_icon(c) %>
-                <%= c.name %>
+                <%= c.display_name %>
               <% end %>
             </li>
           <% end %>
diff --git a/app/views/shared/_show_filter_hint.html.erb b/app/views/shared/_show_filter_hint.html.erb
index 15ced9721..e3f5ed4ee 100644
--- a/app/views/shared/_show_filter_hint.html.erb
+++ b/app/views/shared/_show_filter_hint.html.erb
@@ -1,7 +1,7 @@
 <% if @category.present? %>
   <small>
     <%= glyph :category %>
-    <%= @category.name %>
+    <%= @category.display_name %>
   </small>
 <% end %>
 <% if params[:q].present? %>

From fad704a0d06850db746a138810fff131135f0be3 Mon Sep 17 00:00:00 2001
From: Saverio Trioni <476895+rewritten@users.noreply.github.com>
Date: Thu, 26 Mar 2026 14:09:24 +0100
Subject: [PATCH 2/2] =?UTF-8?q?fix:=20address=20Copilot=20review=20?=
 =?UTF-8?q?=E2=80=94=20guarantee=20display=5Fname=20always=20returns=20a?=
 =?UTF-8?q?=20string?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Fall back to Category.model_name.human when no translations exist at all
- Use display_name explicitly in helper sort to make crash-safety clear
- Use display_name in views for consistent fallback display

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 app/helpers/categories_helper.rb | 2 +-
 app/models/category.rb           | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/app/helpers/categories_helper.rb b/app/helpers/categories_helper.rb
index ee6c29ec5..66a7504b2 100644
--- a/app/helpers/categories_helper.rb
+++ b/app/helpers/categories_helper.rb
@@ -1,6 +1,6 @@
 module CategoriesHelper
   def all_categories
-    @all_categories ||= Category.all.sort_by { |a| a.to_s.downcase }
+    @all_categories ||= Category.all.sort_by { |a| a.display_name.downcase }
   end
 
   def categories_for_select
diff --git a/app/models/category.rb b/app/models/category.rb
index 1adb578b8..ebb39cc40 100644
--- a/app/models/category.rb
+++ b/app/models/category.rb
@@ -7,7 +7,9 @@ def display_name
     return name if name.present?
 
     fallback_locale, fallback_name = name_translations&.find { |_, v| v.present? }
-    "#{fallback_name} [#{fallback_locale}]" if fallback_name
+    return "#{fallback_name} [#{fallback_locale}]" if fallback_name.present?
+
+    self.class.model_name.human
   end
 
   def to_s