From ffdc11c0814588db36ffecc6ae50dfdc767e96a8 Mon Sep 17 00:00:00 2001 From: Anuraag Agrawal Date: Mon, 30 Mar 2026 10:55:21 +0900 Subject: [PATCH 1/2] Recommend sync all-packages by default Signed-off-by: Anuraag Agrawal --- DEVELOPMENT.md | 2 +- README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md index 9864b26..4077866 100644 --- a/DEVELOPMENT.md +++ b/DEVELOPMENT.md @@ -19,7 +19,7 @@ 2. Install dependencies: ```bash - uv sync + uv sync --all-packages ``` ## Development Workflow diff --git a/README.md b/README.md index 3b1172c..8037b34 100644 --- a/README.md +++ b/README.md @@ -405,7 +405,7 @@ We rely on the conformance test suit (in Set up a virtual env: ```sh -uv sync +uv sync --all-packages ``` Then, use `uv run just` to do development checks, or check out `uv run just --list` for other targets. From d5833fd4097157c5c98e0f0aae747f173c942e24 Mon Sep 17 00:00:00 2001 From: Anuraag Agrawal Date: Thu, 2 Apr 2026 11:44:32 +0900 Subject: [PATCH 2/2] Revert and move otel dev dependencies to root with disclaimer Signed-off-by: Anuraag Agrawal --- DEVELOPMENT.md | 2 +- README.md | 2 +- connectrpc-otel/pyproject.toml | 4 ---- pyproject.toml | 11 +++++++++++ uv.lock | 12 ++++++------ 5 files changed, 19 insertions(+), 12 deletions(-) diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md index 4077866..9864b26 100644 --- a/DEVELOPMENT.md +++ b/DEVELOPMENT.md @@ -19,7 +19,7 @@ 2. Install dependencies: ```bash - uv sync --all-packages + uv sync ``` ## Development Workflow diff --git a/README.md b/README.md index 8037b34..3b1172c 100644 --- a/README.md +++ b/README.md @@ -405,7 +405,7 @@ We rely on the conformance test suit (in Set up a virtual env: ```sh -uv sync --all-packages +uv sync ``` Then, use `uv run just` to do development checks, or check out `uv run just --list` for other targets. diff --git a/connectrpc-otel/pyproject.toml b/connectrpc-otel/pyproject.toml index 76770aa..5b652e6 100644 --- a/connectrpc-otel/pyproject.toml +++ b/connectrpc-otel/pyproject.toml @@ -63,10 +63,6 @@ dev = [ # a transitive dependency, so we go ahead and leave it out. "connectrpc>=0.8.0", - "opentelemetry-instrumentation-asgi==0.61b0", - "opentelemetry-instrumentation-wsgi==0.61b0", - "opentelemetry-sdk==1.40.0", - "connect-python-example", "pytest", ] diff --git a/pyproject.toml b/pyproject.toml index 2663be8..b3b8a7d 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -57,6 +57,17 @@ dev = [ "uvicorn==0.42.0", "zstandard==0.25.0", + # dev dependencies only used in subprojects. Optimal structure would include these + # in the subproject itself, but then `uv sync` does not install them from the + # workspace root. We strategically keep them here instead so the entire workspace + # is ready for editing in an IDE with a simple sync command. + # If the below issue is resolved, we can move them back to subprojects and configure + # our default sync setting as --all-packages. + # https://github.com/astral-sh/uv/issues/5737 + "opentelemetry-instrumentation-asgi==0.61b0", + "opentelemetry-instrumentation-wsgi==0.61b0", + "opentelemetry-sdk==1.40.0", + # Versions locked in constraint-dependencies "pytest", "pytest-asyncio", diff --git a/uv.lock b/uv.lock index 3bce48f..bfe5fe7 100644 --- a/uv.lock +++ b/uv.lock @@ -382,6 +382,9 @@ dev = [ { name = "gunicorn" }, { name = "hypercorn" }, { name = "just-bin", marker = "sys_platform != 'win32'" }, + { name = "opentelemetry-instrumentation-asgi" }, + { name = "opentelemetry-instrumentation-wsgi" }, + { name = "opentelemetry-sdk" }, { name = "pyright", extra = ["nodejs"] }, { name = "pytest" }, { name = "pytest-asyncio" }, @@ -417,6 +420,9 @@ dev = [ { name = "gunicorn", specifier = "==25.3.0" }, { name = "hypercorn", specifier = "==0.18.0" }, { name = "just-bin", marker = "sys_platform != 'win32'", specifier = "==1.47.1" }, + { name = "opentelemetry-instrumentation-asgi", specifier = "==0.61b0" }, + { name = "opentelemetry-instrumentation-wsgi", specifier = "==0.61b0" }, + { name = "opentelemetry-sdk", specifier = "==1.40.0" }, { name = "pyright", extras = ["nodejs"], specifier = "==1.1.408" }, { name = "pytest" }, { name = "pytest-asyncio" }, @@ -448,9 +454,6 @@ dependencies = [ dev = [ { name = "connect-python-example" }, { name = "connectrpc" }, - { name = "opentelemetry-instrumentation-asgi" }, - { name = "opentelemetry-instrumentation-wsgi" }, - { name = "opentelemetry-sdk" }, { name = "pytest" }, ] @@ -464,9 +467,6 @@ requires-dist = [ dev = [ { name = "connect-python-example", editable = "example" }, { name = "connectrpc", editable = "." }, - { name = "opentelemetry-instrumentation-asgi", specifier = "==0.61b0" }, - { name = "opentelemetry-instrumentation-wsgi", specifier = "==0.61b0" }, - { name = "opentelemetry-sdk", specifier = "==1.40.0" }, { name = "pytest" }, ]