Skip to content

Commit f5e2e84

Browse files
authored
Skip HTTP/3 conformance tests on macOS (#159)
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
1 parent 5bb2cd5 commit f5e2e84

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

conformance/test/test_client.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,13 @@
2222
"Client Cancellation/**",
2323
]
2424

25-
_flaky_tests = []
25+
_skipped_tests = []
2626
if sys.platform == "darwin":
2727
# TODO: Investigate HTTP/3 conformance test failures on macOS more.
2828
# Currently, it seems to be an issue with the conformance runner itself and we see this log message.
2929
# 2026/03/05 01:54:19 failed to sufficiently increase receive buffer size (was: 768 kiB, wanted: 7168 kiB, got: 6144 kiB). See https://github.com/quic-go/quic-go/wiki/UDP-Buffer-Sizes for details.
30-
_flaky_tests += ["--known-flaky", "**/HTTPVersion:3/**"]
30+
# known-flaky does not work for these errors for some reason so we just skip.
31+
_skipped_tests += ["--skip", "**/HTTPVersion:3/**"]
3132

3233

3334
def test_client_sync(cov: Coverage | None) -> None:
@@ -45,7 +46,7 @@ def test_client_sync(cov: Coverage | None) -> None:
4546
"--mode",
4647
"client",
4748
*_skipped_tests_sync,
48-
*_flaky_tests,
49+
*_skipped_tests,
4950
"--",
5051
*args,
5152
],
@@ -72,7 +73,7 @@ def test_client_async(cov: Coverage | None) -> None:
7273
_config_path,
7374
"--mode",
7475
"client",
75-
*_flaky_tests,
76+
*_skipped_tests,
7677
"--",
7778
*args,
7879
],

0 commit comments

Comments
 (0)