`/librarylist` support in QSYS

[worksofliam]

I finally figured out how we can get QSYS into the standard VS Code explorer.

QsysFs could support two styles of paths:

1. member:/ which returns all objects in the QSYS library (the current implementation)
2. member:/librarylist which returns on the objects in QSYS that are on the configured library list

This means supporting all URLs like this:

• /SNDBX87 could also be /librarylist/SNDNX87
• /SNDBX87/QRPGLESRC could also be /librarylist/SNDBX87/QRPGLESRC
• /SNDBX87/QRPGLESRC/HELLOWORLD.RPGLE could also be /librarylist/SNDBX87/QRPGLESRC/HELLOWORLD.RPGLE

I don't think it will be a lot of work to implement:

1. readDirectory needs to have a filter if it is '/librarylist' and trying to fetch all objects from QSYS
2. Other methods don't have to do any special logic other than strip out the /librarylist

(also, it doesn't have to be /librarylist, it could be anything: /libl, /ibmi, etc)

[worksofliam]

The reason is so we can use the updateWorkspaceFolders with {uri: {scheme: 'member', path: '/librarylist'}}

[worksofliam]

Some considerations. Please look into how often the explorer is calling readDirectory. If it's heavy:

• it shouldn't be used, or
• caching will need to happen as part of this file system provider.

[bobcozzi]

I'm confused. What problem is this trying to solve?

[worksofliam]

@bobcozzi navigating QSYS from the explorer view, along with all other workspace folders.

[pabloto]

So no need to migrate to ifs?

Will git work?

Bye

[worksofliam]

@pabloto no, git won't work. Just another way to access QSYS.

[worksofliam]

Btw, found an easier way to get this to work, simply use a fragment: member:///#libl

in QsysFs.ts:

else if (uri.path === '/') {
    let statement = `select OBJNAME from table (QSYS2.OBJECT_STATISTICS ('*ALLSIMPLE', 'LIB', '*ALLSIMPLE'))`;
    
    const libraryList = connection.getConfig().libraryList;
    if (uri.fragment === `libl`) {
        statement += ` where OBJNAME in (${libraryList.map(entry => `'${connection.upperCaseName(entry)}'`).join(`, `)})`;
        console.log({statement});
    }

    return (await connection.runSQL(statement))
        .map(row => [row.OBJNAME as string, vscode.FileType.Directory]);
}

[bobcozzi]

I am still unclear as to what this is doing. Are you saying that you want to be able to list the objects in QSYS.LIB in the Explorer? If that's it, I didn't realize you couldn't--not that I'd ever want to. If not, then I'm just not getting the contemporary colloquialisms.

[worksofliam]

@bobcozzi browsing QSYS in the Explorer is exactly what I would like. I wanted to do this years ago, but at the time there wasn't a good way to do it.

For me, I use a workspace with multiple workspace folders (like a monorepo) and now I can add the QSYS file system - either libraries in my library list, or specific library - along with my other local folders.

Small PR is opened.

[SanjulaGanepola]

Closing as completed in #3138