Skip to content

ConsoleView: crash on empty history, unused style/state #43

@dmgerman

Description

@dmgerman

Greptile flagged a pre-existing issue in Hammerspoon 2/Windows/ConsoleView.swift during review of PR #42. It is unrelated to that PR's scope.

Out-of-range crash on up-arrow with empty history

When evalHistory is empty, pressing up-arrow sets evalIndex = evalHistory.count - 1 = -1, then accesses evalHistory[-1], which crashes.

#42 (comment)

Fixed in PR #44.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions