closes #112

Author: xrotwang

CHANGES.md

@@ -2,7 +2,8 @@
 
 ## Unreleased
 
-Fixed bug whereby sections with empty content were dropped by `markup.iter_markdown_sections`.
+- Fixed bug whereby sections with empty content were dropped by `markup.iter_markdown_sections`.
+- Fixed bug whereby the "booktitle" field was not rendered in the linearization of a `Source` of genre "inbook".
 
 
 ## 3.24.1

src/clldutils/source.py

@@ -288,7 +288,7 @@ def italicized(s):
             if self.get('doi'):
                 res.append('doi: {}'.format(
                     '[{0}](https://doi.org/{0})'.format(self['doi']) if markdown else self['doi']))
-        elif genre == 'incollection' or genre == 'inproceedings':
+        elif genre in {'incollection', 'inproceedings', 'inbook'}:
             prefix = 'In'
             atom = ''
             if editors:
@@ -299,7 +299,8 @@ def italicized(s):
                 atom += " %s" % italicized(self.get_with_translation('booktitle'))
             if self.get('pages'):
                 atom += ", %s" % self.norm_pages
-            res.append(prefix + atom)
+            if atom:
+                res.append(prefix + atom)
         else:
             # check for author to make sure we haven't included the editors yet.
             if editors and self.get('author'):
@@ -315,7 +316,7 @@ def italicized(s):
             if self.get('issue'):
                 res.append("(%s)" % self['issue'])
 
-            if not pages_at_end and self.get('pages'):
+            if not pages_at_end and self.get('pages'):  # pragma: no cover
                 res.append(self.norm_pages)
 
         thesis_handled = False

tests/test_source.py

@@ -116,7 +116,17 @@ def test_striptex():
   volume    = {2}
 }""",
                 "Healey, Alan. n.d. History of research in Austronesian languages: "
-                "Admiralty Islands area. 2. 223-232."),
+                "Admiralty Islands area. In New Guinea area languages and language study, 223-232."),
+        (
+                """@misc{316361,
+  author    = {Healey, Alan},
+  booktitle = {New Guinea area languages and language study},
+  pages     = {223-232},
+  title     = {History of research in Austronesian languages: Admiralty Islands area},
+  volume    = {2}
+}""",
+                "Healey, Alan. n.d. History of research in Austronesian languages: "
+                "Admiralty Islands area. 2. 223-232pp."),
         (
                 """@incollection{316361,
   author    = {Healey, Alan},