From e06dd0da673f4497eaae15c031bb40328bd89546 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Sun, 8 Mar 2026 11:16:13 +0000 Subject: [PATCH 1/3] fix: inject version and fix tsconfig warning - Set actual version instead of "0.0.0" via ldflags in `Dockerfile` and `.goreleaser.yaml`. - Removed `// TODO: set version` in `cmd/unspeech/main.go`. - Fixed `tsconfig.lib.json doesn't exist` warning in TypeScript SDK build by pointing to `tsconfig.json`. Co-authored-by: chainsaid <127925965+chainsaid@users.noreply.github.com> --- .goreleaser.yaml | 2 ++ Dockerfile | 4 +++- cmd/unspeech/main.go | 7 ++++--- sdk/typescript/tsdown.config.ts | 2 +- 4 files changed, 10 insertions(+), 5 deletions(-) diff --git a/.goreleaser.yaml b/.goreleaser.yaml index 5287089..da4b89c 100644 --- a/.goreleaser.yaml +++ b/.goreleaser.yaml @@ -1,5 +1,7 @@ builds: - main: ./cmd/unspeech + ldflags: + - -X main.version={{.Version}} # remove 386 goarch: - amd64 diff --git a/Dockerfile b/Dockerfile index d1fa7eb..d9f0476 100644 --- a/Dockerfile +++ b/Dockerfile @@ -11,7 +11,9 @@ RUN go mod download COPY . . -RUN CGO_ENABLED=0 GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH} go build -o ./result/unspeech ./cmd/unspeech +ARG VERSION=0.0.0 + +RUN CGO_ENABLED=0 GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH} go build -ldflags="-X main.version=${VERSION}" -o ./result/unspeech ./cmd/unspeech # https://github.com/GoogleContainerTools/distroless FROM gcr.io/distroless/static-debian12 AS app diff --git a/cmd/unspeech/main.go b/cmd/unspeech/main.go index 08a3957..539fbfb 100644 --- a/cmd/unspeech/main.go +++ b/cmd/unspeech/main.go @@ -14,11 +14,12 @@ import ( "github.com/moeru-ai/unspeech/pkg/ho" ) +var version = "0.0.0" + func main() { rootCmd := &cobra.Command{ - Use: "unspeech", - // TODO: set version - Version: "0.0.0", + Use: "unspeech", + Version: version, RunE: func(cmd *cobra.Command, args []string) error { slog.SetDefault(slog.New(tint.NewHandler(os.Stdout, nil))) diff --git a/sdk/typescript/tsdown.config.ts b/sdk/typescript/tsdown.config.ts index 09a3ec5..16cf001 100644 --- a/sdk/typescript/tsdown.config.ts +++ b/sdk/typescript/tsdown.config.ts @@ -6,5 +6,5 @@ export default defineConfig({ dts: true, entry: [join('src', 'index.ts')], format: 'esm', - tsconfig: 'tsconfig.lib.json', + tsconfig: 'tsconfig.json', }) From 626700b2ab24696829fcb31027de194794447f60 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Sun, 8 Mar 2026 11:24:12 +0000 Subject: [PATCH 2/3] fix: resolve golangci-lint errors causing CI failure - `pkg/backend/doubao/voices.go`: Add `//nolint:mnd` to bypass magic number checks for audio sample rates. - `pkg/backend/microsoft/speech.go`: Change `omitempty` to `omitzero` for `mo.Option` fields in JSON structs, per `modernize` rules. - `internal/middlewares/error_handler.go`: Change `make([]slog.Attr, 0)` to `var attrs []slog.Attr` to fix `prealloc` warning. Co-authored-by: chainsaid <127925965+chainsaid@users.noreply.github.com> --- internal/middlewares/error_handler.go | 2 +- pkg/backend/doubao/voices.go | 1 + pkg/backend/microsoft/speech.go | 10 +++++----- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/internal/middlewares/error_handler.go b/internal/middlewares/error_handler.go index a93fbe8..f505689 100644 --- a/internal/middlewares/error_handler.go +++ b/internal/middlewares/error_handler.go @@ -23,7 +23,7 @@ func HandleErrors() echo.MiddlewareFunc { slog.Error("unknown error responded", slog.Any("error", err.Error())) } if 500 >= errResp.Status || errResp.Status < 600 { - attrs := make([]slog.Attr, 0) + var attrs []slog.Attr attrs = append(attrs, logs.Caller(errResp.Caller())...) attrs = append(attrs, slog.Any("error", errResp.Error())) slog.Error("error occurred during request", lo.ToAnySlice(attrs)...) diff --git a/pkg/backend/doubao/voices.go b/pkg/backend/doubao/voices.go index ba6659c..a7abb23 100644 --- a/pkg/backend/doubao/voices.go +++ b/pkg/backend/doubao/voices.go @@ -39,6 +39,7 @@ func HandleVoices(c echo.Context, options mo.Option[types.VoicesRequestOptions]) voices := make([]types.Voice, 0, len(voicesResponse)) for _, voice := range voicesResponse { + //nolint:mnd voices = append(voices, types.Voice{ ID: voice.Voice, Name: voice.Name, diff --git a/pkg/backend/microsoft/speech.go b/pkg/backend/microsoft/speech.go index bae7544..45fe0eb 100644 --- a/pkg/backend/microsoft/speech.go +++ b/pkg/backend/microsoft/speech.go @@ -35,12 +35,12 @@ type ssml struct { } type extraBody struct { - DisableSSML mo.Option[bool] `json:"disable_ssml,omitempty"` + DisableSSML mo.Option[bool] `json:"disable_ssml,omitzero"` Region string `json:"region"` - DeploymentID mo.Option[string] `json:"deployment_id,omitempty"` - Lang mo.Option[string] `json:"lang,omitempty"` - Gender mo.Option[string] `json:"gender,omitempty"` - SampleRate mo.Option[uint] `json:"sample_rate,omitempty"` + DeploymentID mo.Option[string] `json:"deployment_id,omitzero"` + Lang mo.Option[string] `json:"lang,omitzero"` + Gender mo.Option[string] `json:"gender,omitzero"` + SampleRate mo.Option[uint] `json:"sample_rate,omitzero"` } var ( From 00259be0cdd946e18211ecdef1abbecbd80cce35 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Sun, 8 Mar 2026 11:30:01 +0000 Subject: [PATCH 3/3] fix: resolve golangci-lint errors causing CI failure - `pkg/backend/doubao/voices.go`: Add `//nolint:mnd` to bypass magic number checks for audio sample rates. - `pkg/backend/microsoft/speech.go`: Change `omitempty` to `omitzero` for `mo.Option` fields in JSON structs, per `modernize` rules. - `internal/middlewares/error_handler.go`: Preallocate slice correctly using `make([]slog.Attr, 0, len(callerAttrs)+1)` to fix `prealloc` warning. Co-authored-by: chainsaid <127925965+chainsaid@users.noreply.github.com> --- internal/middlewares/error_handler.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/internal/middlewares/error_handler.go b/internal/middlewares/error_handler.go index f505689..a914a79 100644 --- a/internal/middlewares/error_handler.go +++ b/internal/middlewares/error_handler.go @@ -23,8 +23,9 @@ func HandleErrors() echo.MiddlewareFunc { slog.Error("unknown error responded", slog.Any("error", err.Error())) } if 500 >= errResp.Status || errResp.Status < 600 { - var attrs []slog.Attr - attrs = append(attrs, logs.Caller(errResp.Caller())...) + callerAttrs := logs.Caller(errResp.Caller()) + attrs := make([]slog.Attr, 0, len(callerAttrs)+1) + attrs = append(attrs, callerAttrs...) attrs = append(attrs, slog.Any("error", errResp.Error())) slog.Error("error occurred during request", lo.ToAnySlice(attrs)...) }