From 3e828696773b264a1d0d85e71637feff81603079 Mon Sep 17 00:00:00 2001 From: Leo Farias Date: Wed, 11 Mar 2026 11:09:51 -0400 Subject: [PATCH 1/2] refactor: remove slide error factory --- packages/core/CHANGELOG.md | 5 ++ packages/core/lib/src/models/slide_model.dart | 29 ------------ .../test/src/models/slide_model_test.dart | 47 ------------------- 3 files changed, 5 insertions(+), 76 deletions(-) diff --git a/packages/core/CHANGELOG.md b/packages/core/CHANGELOG.md index a659aaf0..6291fbee 100644 --- a/packages/core/CHANGELOG.md +++ b/packages/core/CHANGELOG.md @@ -1,3 +1,8 @@ +## Next + +- Remove the unused `Slide.error(...)` factory from the public API; deck loading + errors continue through `DeckErrorEvent`. + ## 1.0.0 - First stable release of superdeck_core diff --git a/packages/core/lib/src/models/slide_model.dart b/packages/core/lib/src/models/slide_model.dart index 44d0d30e..108d8d3a 100644 --- a/packages/core/lib/src/models/slide_model.dart +++ b/packages/core/lib/src/models/slide_model.dart @@ -72,35 +72,6 @@ class Slide with SlideMappable { /// Validates [map] against the schema and constructs a [Slide]. static Slide parse(Map map) => fromMap(schema.parse(map)!); - - /// Creates an error slide to display errors in the presentation. - /// - /// This slide is automatically generated when there are parsing errors - /// or other issues loading the presentation. - static Slide error({ - required String title, - required String message, - required Exception error, - }) { - return Slide( - key: 'error', - sections: [ - SectionBlock([ - ContentBlock(''' -> [!CAUTION] -> $title -> $message - - -```dart -${error.toString()} -``` -'''), - ContentBlock(''), - ]), - ], - ); - } } /// Configuration options for a slide. diff --git a/packages/core/test/src/models/slide_model_test.dart b/packages/core/test/src/models/slide_model_test.dart index af9de76d..0ce97b07 100644 --- a/packages/core/test/src/models/slide_model_test.dart +++ b/packages/core/test/src/models/slide_model_test.dart @@ -266,53 +266,6 @@ void main() { }); }); - group('error factory', () { - test('creates error slide with correct key', () { - final slide = Slide.error( - title: 'Error Title', - message: 'Error message', - error: Exception('Test error'), - ); - - expect(slide.key, 'error'); - }); - - test('includes title and message in content', () { - final slide = Slide.error( - title: 'Parse Error', - message: 'Could not parse slide', - error: Exception('Details'), - ); - - final content = (slide.sections[0].blocks[0] as ContentBlock).content; - expect(content.contains('Parse Error'), isTrue); - expect(content.contains('Could not parse slide'), isTrue); - }); - - test('includes error details in code block', () { - final slide = Slide.error( - title: 'Error', - message: 'Message', - error: Exception('Detailed error info'), - ); - - final content = (slide.sections[0].blocks[0] as ContentBlock).content; - expect(content.contains('Detailed error info'), isTrue); - expect(content.contains('```dart'), isTrue); - }); - - test('creates section with two content blocks', () { - final slide = Slide.error( - title: 'E', - message: 'M', - error: Exception('X'), - ); - - expect(slide.sections.length, 1); - expect(slide.sections[0].blocks.length, 2); - }); - }); - group('equality', () { test('equal slides are equal', () { final slide1 = Slide(key: 'same', comments: ['note']); From 091cc21ea8005eb5cbe55d501d6b71a21b32daa1 Mon Sep 17 00:00:00 2001 From: Leo Farias Date: Wed, 11 Mar 2026 11:11:54 -0400 Subject: [PATCH 2/2] chore: drop changelog note --- packages/core/CHANGELOG.md | 5 ----- 1 file changed, 5 deletions(-) diff --git a/packages/core/CHANGELOG.md b/packages/core/CHANGELOG.md index 6291fbee..a659aaf0 100644 --- a/packages/core/CHANGELOG.md +++ b/packages/core/CHANGELOG.md @@ -1,8 +1,3 @@ -## Next - -- Remove the unused `Slide.error(...)` factory from the public API; deck loading - errors continue through `DeckErrorEvent`. - ## 1.0.0 - First stable release of superdeck_core