Skip to content

Commit 2b747bd

Browse files
committed
[buildmgr] Enforce toolchain registration environment variables
1 parent 299dfc3 commit 2b747bd

28 files changed

Lines changed: 58 additions & 31 deletions

File tree

.github/workflows/buildmgr.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -308,6 +308,7 @@ jobs:
308308
CI_CBUILD_INSTALLER: ${{ github.workspace }}/cbuild_install.sh
309309
CMSIS_PACK_ROOT: ${{ github.workspace }}/packs
310310
GCC_TOOLCHAIN_ROOT: ${{ github.workspace }}/${{ matrix.toolchain_root }}
311+
GCC_TOOLCHAIN_10_3_1: ${{ github.workspace }}/${{ matrix.toolchain_root }}
311312
CI_ARCH: ${{ matrix.arch }}
312313
strategy:
313314
#fail-fast: true

tools/buildmgr/cbuild/src/CbuildModel.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -473,10 +473,9 @@ bool CbuildModel::GetCompatibleToolchain(const string& name, const string& versi
473473
}
474474

475475
if (selectedVersion.empty()) {
476-
// no compatible registered toolchain was found, search for a suitable config file
477-
if (GetToolchainConfig(toolchainConfigFiles, name, versionRange)) {
478-
return true;
479-
}
476+
// no compatible registered toolchain was found
477+
LogMsg("M616", VAL("NAME", name));
478+
return false;
480479
} else {
481480
// registered toolchain was found
482481
m_toolchainRegisteredVersion = selectedVersion;

tools/buildmgr/cbuild/src/CbuildMsgs.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ void InitMessageTable()
8282
table["M613"] = MessageEntry(MsgLevel::LEVEL_ERROR, CRLF_B, "File '%PATH%' has unexpected format!" );
8383
table["M614"] = MessageEntry(MsgLevel::LEVEL_ERROR, CRLF_B, "Missing access sequence delimiter: '%ACCSEQDELIM%'!" );
8484
table["M615"] = MessageEntry(MsgLevel::LEVEL_ERROR, CRLF_B, "%PROP% '%VAL%' was not found in the loaded packs!" );
85+
table["M616"] = MessageEntry(MsgLevel::LEVEL_ERROR, CRLF_B, "compiler registration environment variable missing, format: %NAME%_TOOLCHAIN_<major>_<minor>_<patch>");
8586

8687
table["M630"] = MessageEntry(MsgLevel::LEVEL_WARNING, CRLF_B, "Device '%DEV%' is substituted with variant '%VAR%'." );
8788
table["M631"] = MessageEntry(MsgLevel::LEVEL_WARNING, CRLF_B, "Project must have exactly one target element!" );

tools/buildmgr/test/testinput/Examples/GCC/AccessSequence/CMakeLists.txt.ref

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,8 @@ set(CXX_FLAGS_C:/Temp/devtools/tools/buildmgr/test/testinput/Examples/GCC/Access
128128

129129
# Toolchain config map
130130

131+
set(REGISTERED_TOOLCHAIN_ROOT "C:/Compilers/GCC/10.3.1/bin")
132+
set(REGISTERED_TOOLCHAIN_VERSION "10.3.1")
131133
set(TOOLCHAIN_VERSION_MIN "9.2.1")
132134
include ("C:/sandbox/cbuild/etc/GCC.10.3.1.cmake")
133135
include ("C:/sandbox/cbuild/etc/CMSIS-Build-Utils.cmake")

tools/buildmgr/test/testinput/Examples/GCC/Asm/CMakeLists.txt.ref

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,8 @@ set(AS_FLAGS_C:/sandbox/devtools/build/TestOutput/TestData/Examples/GCC/Asm/GAS.
125125

126126
# Toolchain config map
127127

128+
set(REGISTERED_TOOLCHAIN_ROOT "C:/Compilers/GCC/10.3.1/bin")
129+
set(REGISTERED_TOOLCHAIN_VERSION "10.3.1")
128130
set(TOOLCHAIN_VERSION_MIN "9.2.1")
129131
include ("C:/sandbox/cbuild/etc/GCC.10.3.1.cmake")
130132
include ("C:/sandbox/cbuild/etc/CMSIS-Build-Utils.cmake")

tools/buildmgr/test/testinput/Examples/GCC/BranchProtection/CMakeLists.txt.ref

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@ set(LIB_FILES
4848

4949
# Toolchain config map
5050

51+
set(REGISTERED_TOOLCHAIN_ROOT "C:/Compilers/GCC/10.3.1/bin")
52+
set(REGISTERED_TOOLCHAIN_VERSION "10.3.1")
5153
set(TOOLCHAIN_VERSION_MIN "10.2.1")
5254
include ("C:/sandbox/cbuild/etc/GCC.10.3.1.cmake")
5355
include ("C:/sandbox/cbuild/etc/CMSIS-Build-Utils.cmake")

tools/buildmgr/test/testinput/Examples/GCC/Build_GCC/CMakeLists.txt.ref

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,8 @@ set(LIB_FILES
5151

5252
# Toolchain config map
5353

54+
set(REGISTERED_TOOLCHAIN_ROOT "C:/Compilers/GCC/10.3.1/bin")
55+
set(REGISTERED_TOOLCHAIN_VERSION "10.3.1")
5456
set(TOOLCHAIN_VERSION_MIN "9.2.1")
5557
include ("C:/sandbox/cbuild/etc/GCC.10.3.1.cmake")
5658
include ("C:/sandbox/cbuild/etc/CMSIS-Build-Utils.cmake")

tools/buildmgr/test/testinput/Examples/GCC/Build_GPP/CMakeLists.txt.ref

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ set(LIB_FILES
5555

5656
# Toolchain config map
5757

58+
set(REGISTERED_TOOLCHAIN_ROOT "C:/Compilers/GCC/10.3.1/bin")
59+
set(REGISTERED_TOOLCHAIN_VERSION "10.3.1")
5860
set(TOOLCHAIN_VERSION_MIN "9.2.1")
5961
include ("C:/sandbox/cbuild/etc/GCC.10.3.1.cmake")
6062
include ("C:/sandbox/cbuild/etc/CMSIS-Build-Utils.cmake")

tools/buildmgr/test/testinput/Examples/GCC/DupFilename/CMakeLists.txt.ref

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ set(CC_SRC_FILES
3232

3333
# Toolchain config map
3434

35+
set(REGISTERED_TOOLCHAIN_ROOT "C:/Compilers/GCC/10.3.1/bin")
36+
set(REGISTERED_TOOLCHAIN_VERSION "10.3.1")
3537
set(TOOLCHAIN_VERSION_MIN "9.2.1")
3638
include ("C:/sandbox/cbuild/etc/GCC.10.3.1.cmake")
3739
include ("C:/sandbox/cbuild/etc/CMSIS-Build-Utils.cmake")

tools/buildmgr/test/testinput/Examples/GCC/FlagOrder/CMakeLists.txt.ref

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ set(CC_SRC_FILES
3838

3939
# Toolchain config map
4040

41+
set(REGISTERED_TOOLCHAIN_ROOT "C:/Compilers/GCC/10.3.1/bin")
42+
set(REGISTERED_TOOLCHAIN_VERSION "10.3.1")
4143
set(TOOLCHAIN_VERSION_MIN "9.2.1")
4244
include ("C:/sandbox/cbuild/etc/GCC.10.3.1.cmake")
4345
include ("C:/sandbox/cbuild/etc/CMSIS-Build-Utils.cmake")

0 commit comments

Comments
 (0)