test(shared): extract push fixtures to shared module#48
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📊 Coverage Report
🤖 Generated by CI · thresholds enforced via vitest |
…fixtures.ts The `makeUser`, `makeProblem`, `makeChannel` helpers were duplicated across push pipeline test files. Hoisted to a shared fixtures module so a schema change only touches one file instead of every suite. push.pipeline.test.ts migrated to use the shared fixtures. Other test files (push.pipeline.paused.test.ts, push.worker.test.ts) construct their own specialised mocks and are left untouched for now — they can migrate incrementally without a forcing function. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bolin8017
force-pushed
the
test/shared-fixtures
branch
from
2c8de68 to
a8faef2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts duplicated `makeUser` / `makeProblem` / `makeChannel` factories into `packages/shared/src/tests/fixtures.ts`. Also adds `makePushMessage` for PushMessage construction. `push.pipeline.test.ts` migrated; other suites can follow incrementally.
Test plan
🤖 Generated with Claude Code