From 6ea344c2a1609c9217b5d5b3c07f7f6ae0a563c6 Mon Sep 17 00:00:00 2001 From: Joaquin Date: Tue, 3 Mar 2026 13:11:08 -0500 Subject: [PATCH] feat: read ESTELA_SPIDER_ARGS from environment variable - Read ESTELA_SPIDER_ARGS from env instead of hardcoding empty string - Fix pre-existing ruff errors (format strings, duplicate test name, noqa) Co-Authored-By: Claude Opus 4.6 --- estela_requests/config.py | 4 ++-- estela_requests/middlewares/tests/test_stats.py | 2 +- estela_requests/request_interfaces.py | 2 +- estela_requests/settings_remote.py | 3 ++- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/estela_requests/config.py b/estela_requests/config.py index 641e8cd..3e45825 100644 --- a/estela_requests/config.py +++ b/estela_requests/config.py @@ -18,6 +18,6 @@ settings_files= settings_files_list, ) -print("Settings file list: %s" % settings_files_list) +print(f"Settings file list: {settings_files_list}") sett_as_dict = settings.as_dict() -print("Settings obtained: %s" % sett_as_dict) +print(f"Settings obtained: {sett_as_dict}") diff --git a/estela_requests/middlewares/tests/test_stats.py b/estela_requests/middlewares/tests/test_stats.py index 42a551e..5136d6a 100644 --- a/estela_requests/middlewares/tests/test_stats.py +++ b/estela_requests/middlewares/tests/test_stats.py @@ -67,7 +67,7 @@ def test_after_session_updates_stats_correctly(self): assert middleware.stats['downloader/request_count'] == 0 assert middleware.stats['response_received_count'] == 0 - def test_after_session_updates_stats_correctly(self): + def test_before_session_sets_start_time(self): producer = Mock(spec=ProducerInterface) topic = 'test_topic' metadata = {'jid': 'test_job'} diff --git a/estela_requests/request_interfaces.py b/estela_requests/request_interfaces.py index 36073d7..d25144e 100644 --- a/estela_requests/request_interfaces.py +++ b/estela_requests/request_interfaces.py @@ -12,4 +12,4 @@ def request(self, *args, **kwargs): class RequestsInterface(HttpRequestInterface): def request(self, *args, **kwargs): - return requests.request(*args, **kwargs) + return requests.request(*args, **kwargs) # noqa: S113 diff --git a/estela_requests/settings_remote.py b/estela_requests/settings_remote.py index 189ae2f..5293d0c 100644 --- a/estela_requests/settings_remote.py +++ b/estela_requests/settings_remote.py @@ -1,4 +1,5 @@ import logging +import os from estela_queue_adapter.get_interface import get_producer_interface @@ -13,7 +14,7 @@ HTTP_CLIENT = RequestsInterface() ESTELA_API_HOST = "http://127.0.0.1" ESTELA_SPIDER_JOB = "101.madbymike.4796d37b-698b-4684-83c8-e3763c8d32ba" -ESTELA_SPIDER_ARGS = "" +ESTELA_SPIDER_ARGS = os.environ.get("ESTELA_SPIDER_ARGS", "") ESTELA_ITEM_PIPELINES = [] ESTELA_ITEM_EXPORTERS = [KafkaItemExporter] ESTELA_LOG_LEVEL = logging.DEBUG