marginalization example fails due to time_jitter

[ruxandrab7]

Hi,

I ran the marginalized_likelihood.py example in a clean bilby installation. It failed with the last line of the error being
KeyError: 'time_jitter'

Inspired by the closed issue [https://github.com//issues/772)] I added
time_jitter=0. to injection_parameters. Now the code runs. Should the example be updated, i.e., through a merge request? Or can the problem be solved in bilby itself?

Thanks,

Ruxandra

[mj-will]

Thanks for reporting this @ruxandrab7, could you post the full traceback?

[ruxandrab7]

Hi, I am attaching the full trace-back below.

Thanks,
Ruxandra

1598it [00:00, ?it/s]19:57 bilby INFO : Written checkpoint file outdir/marginalized_likelihood_resume.pickle
1597it [00:03, -0.29it/s, bound:0 nc: 1 ncall:1.3e+04 eff:17.4% logz-ratio=11.32+/-0.01 dlogz:0.00019>0.1]

19:57 bilby INFO : Rejection sampling nested samples to obtain 1065 posterior samples
19:57 bilby INFO : Sampling time: 0:00:34.324228
19:57 bilby WARNING : Result.save_to_file called with extension=True. This will default to json, and ignore the extension from the filename. This behaviour is deprecated and will be removed.
Traceback (most recent call last):
File "/Users/ruxandra/local_bilby_runs/marg_test/marginalized_likelihood.py", line 104, in
result = bilby.run_sampler(
^^^^^^^^^^^^^^^^^^
File "/Users/ruxandra/opt/anaconda3/envs/bilby/lib/python3.11/site-packages/bilby/core/sampler/init.py", line 345, in run_sampler
result.injection_parameters = conversion_function(
^^^^^^^^^^^^^^^^^^^^
File "/Users/ruxandra/opt/anaconda3/envs/bilby/lib/python3.11/site-packages/bilby/gw/conversion.py", line 1729, in generate_all_bbh_parameters
output_sample = _generate_all_cbc_parameters(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/ruxandra/opt/anaconda3/envs/bilby/lib/python3.11/site-packages/bilby/gw/conversion.py", line 1650, in _generate_all_cbc_parameters
compute_per_detector_log_likelihoods(
File "/Users/ruxandra/opt/anaconda3/envs/bilby/lib/python3.11/site-packages/bilby/gw/conversion.py", line 2317, in compute_per_detector_log_likelihoods
samples = likelihood.compute_per_detector_log_likelihood(samples)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/ruxandra/opt/anaconda3/envs/bilby/lib/python3.11/site-packages/bilby/gw/likelihood/base.py", line 477, in compute_per_detector_log_likelihood
parameters['geocent_time'] += parameters['time_jitter']
~~~~~~~~~~^^^^^^^^^^^^^^^
KeyError: 'time_jitter'

[mj-will]

I've looked into this and I think it is caused by the change in: #900.

@ColmTalbot any thoughts on how to best address this? I think it's the same issue that led to this comment/change: #941 (comment)