-
-
Notifications
You must be signed in to change notification settings - Fork 73
Turn on revive linter in golangci config #442
Copy link
Copy link
Open
Labels
devopsImprovements to DevOps (e.g. GitHub actions, linting, etc.)Improvements to DevOps (e.g. GitHub actions, linting, etc.)enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededlow priorityWould be nice to fix, but doesn't have to happen right now/there are more important thingsWould be nice to fix, but doesn't have to happen right now/there are more important thingsstale
Description
Metadata
Metadata
Assignees
Labels
devopsImprovements to DevOps (e.g. GitHub actions, linting, etc.)Improvements to DevOps (e.g. GitHub actions, linting, etc.)enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededlow priorityWould be nice to fix, but doesn't have to happen right now/there are more important thingsWould be nice to fix, but doesn't have to happen right now/there are more important thingsstale
Describe the desired feature/enhancement
Seems like
golangcidropped support forgolinta few versions ago. IMO, we should definitely have some sort of linting enabled!Is your feature request related to a problem?
The problem: I cannot stand unlinted codebases!
Describe the solution you'd like
Add
revive, a drop-in replacement forgolint, to the list of enabled linters.golangci.yml.This will require going through the entire codebase and fixing all of the errors until
just lintis happy. Runninggolangci-lint -c .golangci.yml run --fixwill take you part of the way there. It would probably also be good to add another entry to thejustfilecalledlint-fixthat runsgolangci-lint -c .golangci.yml run --fix, or allow the user to pass additional arguments to thelinttarget (e.g.just lint --fix).Describe alternatives you've considered (optional)
We could just leave the linter off, but that would make me sad :(
Additional context
Add any other context or screenshots about the feature request here.