Skip to content
This repository was archived by the owner on Mar 13, 2026. It is now read-only.
This repository was archived by the owner on Mar 13, 2026. It is now read-only.

Replace Switch with Pulling from Map #3

@Ellisande

Description

@Ellisande

When adding the class for reveal you can replace the switch statement since you already have a map declared.

      switch (settings.reveal) {
        case 'bottom':
          $(settings.panel).addClass(classes.bottom);
          break;
        case 'left':
          $(settings.panel).addClass(classes.left);
          break;
        case 'right':
          $(settings.panel).addClass(classes.right);
          break;
        case 'fade':
          $(settings.panel).addClass(classes.fade);
          break;
        default:
          $(settings.panel).addClass(classes.top);
          break;
      }

can easily be re-written as

   $(settings.panel).addClass(classes[settings.reveal] || classes.top)

Reduces the lines of code and get rid of the often problematic break; requirement between cases.

https://github.com/bebaps/clear-menu/blob/master/src/clearmenu.js#L32

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions