Skip to content

Commit 1ee77a0

Browse files
author
Jan Miksovsky
committed
Update components in preparation for 0.6.3 release
1 parent 196dcbb commit 1ee77a0

2 files changed

Lines changed: 15 additions & 6 deletions

File tree

basic-tap-selection.html

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,19 @@
2525
is: 'basic-tap-selection',
2626

2727
ready: function() {
28-
this.addEventListener('click', function(event) {
28+
/*
29+
* REVIEW: Which event should we listen to here?
30+
*
31+
* The standard use for this aspect is in list boxes. List boxes don't
32+
* appear to be consistent with regard to whether they select on mousedown
33+
* or click/mouseup.
34+
*/
35+
this.addEventListener('mousedown', function(event) {
2936
this._selectElement(event.target);
30-
// event.stopPropagation();
31-
// return false;
37+
// Note: We don't call preventDefault here. The default behavior for
38+
// mousedown includes setting keyboard focus if the element doesn't
39+
// already have the focus, and we want to preserve that behavior.
40+
event.stopPropagation();
3241
}.bind(this));
3342
},
3443

bower.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
{
22
"name": "basic-tap-selection",
33
"description": "Aspect which maps the tap gesture to item selection.",
4-
"version": "0.6.2",
4+
"version": "0.6.3",
55
"license": "MIT",
66
"main": "basic-tap-selection.html",
77
"dependencies": {
8-
"basic-aspect": "basic-web-components/basic-aspect#0.6.2",
8+
"basic-aspect": "basic-web-components/basic-aspect#0.6.3",
99
"polymer": "Polymer/polymer#^1.1"
1010
},
1111
"devDependencies": {
12-
"basic-framed-content": "basic-web-components/basic-framed-content#0.6.2",
12+
"basic-framed-content": "basic-web-components/basic-framed-content#0.6.3",
1313
"web-component-tester": "*"
1414
},
1515
"keywords": [

0 commit comments

Comments
 (0)