fix: improve ApplicationData typization

[mandrake-sw]

https://github.com/innovation-system/node-bacnet/blob/master/src/lib/types.ts

[jacoscaz]

If something like what I've done for bacnet-device can work for you I'd be happy to upstream it:

https://github.com/jacoscaz/bacnet-device/blob/dca65a75085ebfcb6da3e76d8a40e63d1af43748/src/value.ts#L33-L42

[robertsLando]

Yep would be perfect! Thanks 🙏🏼 In general I would like to get rid of all missing any we have in the code

[jacoscaz]

A complete implementation of what I proposed above would depend on figuring out the typings for all entries in this interface: https://github.com/jacoscaz/bacnet-device/blob/dca65a75085ebfcb6da3e76d8a40e63d1af43748/src/value.ts#L62-L95 . I'm still relatively inexperienced with BACnet so I don't expect that to happen anytime soon. However, there's probably an argument for doing this right away and leaving untyped payloads set to any, so that we don't break anything but still lay some good scaffolding for future incremental work.

What do you think?

[robertsLando]

there's probably an argument for doing this right away and leaving untyped payloads set to any, so that we don't break anything but still lay some good scaffolding for future incremental work.

It's ok for me 👍🏼

[jacoscaz]

Now that #35 has been merged, the next steps for this are:

• Replace all instances of any in the ApplicationTagValueTypeMap interface with proper types
  • ApplicationTag.OCTET_STRING
  • ApplicationTag.EMPTYLIST
  • ApplicationTag.WEEKNDAY
  • ApplicationTag.DATERANGE
  • ApplicationTag.DATETIME
  • ApplicationTag.ERROR
  • ApplicationTag.OBJECT_PROPERTY_REFERENCE
  • ApplicationTag.DESTINATION
  • ApplicationTag.CALENDAR_ENTRY
  • ApplicationTag.WEEKLY_SCHEDULE
  • ApplicationTag.SPECIAL_EVENT
  • ApplicationTag.READ_ACCESS_SPECIFICATION
  • ApplicationTag.READ_ACCESS_RESULT
  • ApplicationTag.LIGHTING_COMMAND
  • ApplicationTag.CONTEXT_SPECIFIC_DECODED
  • ApplicationTag.CONTEXT_SPECIFIC_ENCODED
  • ApplicationTag.LOG_RECORD
• Remove default value for the generic Tag parameter in the BACNetAppData interface and the TypeValue interface, tweaking the codebase wherever needed