v8 Beta Feedback

[Hawxy]

Hiya,
I'm the maintainer of the https://github.com/Hawxy/Auth0Net.DependencyInjection package that's used by a significant number of Auth0.Net consumers. Looking at v8, I have some feedback on some improvements that could be made:

1. Some of the response nullability seems to be a bit off. The UserResponseSchema has UserId as nullable which I'm not sure is even possible? There might be something wrong with the annotations in the schema document this was generated from.

2. ManagementClient isn't a wrapper at the moment, it's more of a reimplementation of ManagementApiClient. It doesn't implement the IManagementApiClient interface (which is a backwards step over v7), decorate the client, or inherit from the client. Maybe something to consider to improve ergonomics & testability.

3. The TokenProvider func option isn't very usable - it only exposes a sync codepath which isn't acceptable in the current year. The implementation of the token provider itself also does a lot of sync-over-async which is simply going to harm performance. I'd suggest exposing an ITokenProvider interface with a ValueTask-returning function to users and allow them to implement their own type. It's an easy change that you can see on the branch here: Hawxy@33aeb82

Otherwise this a good direction and a welcome improvement.

[kailash-b]

Hello @Hawxy, 👋

Thank you for taking the time to test the new package and for providing such detailed and valuable feedback. We sincerely appreciate your insights and your contribution to improving the SDK.

We acknowledge the points you have raised and want to assure you that we are committed to addressing them to enhance the developer experience. Here is our perspective on your suggestions:

Some of the response nullability seems to be a bit off. The UserResponseSchema has UserId as nullable which I'm not sure is even possible? There might be something wrong with the annotations in the schema document this was generated from.

You've correctly identified an issue with the nullability of certain properties like UserId. This discrepancy arises because the underlying schema does not currently annotate this field as required. We will discuss internally to see if we can correct this and other similar instances to ensure our response models are more accurate and predictable.

ManagementClient isn't a wrapper at the moment, it's more of a reimplementation of ManagementApiClient. It doesn't implement the IManagementApiClient interface (which is a backwards step over v7), decorate the client, or inherit from the client. Maybe something to consider to improve ergonomics & testability.

We agree. This is already on our radar, and we are working on a refactor to align it properly with the IManagementApiClient interface. You can expect to see significant improvements in this area in our next beta release.

The TokenProvider func option isn't very usable - it only exposes a sync codepath which isn't acceptable in the current year... I'd suggest exposing an ITokenProvider interface with a ValueTask-returning function to users and allow them to implement their own type.

This is excellent feedback, and we appreciate you highlighting this critical area for improvement. Thank you for going the extra mile to provide a sample implementation. We will make improvements on this in the next beta release.

Once again, thank you for your thorough review and constructive suggestions. 🤝
We value community feedback immensely and will keep this issue updated as we make progress.

[kailash-b]

Hey @Hawxy 👋

🔊 We have a new beta version of the SDK out!

The new release incorporates the feedback we have had internally and from the community and is released as an upgrade in experience as well as feature coverage.

Looking forward to making the SDK better with your feedback! 🤝

[Hawxy]

The major issues raised appear to have been resolved, although the nullability issues still remain

[BrechtLaitem]

I don't get why this is closed. The nullability concern of @Hawxy is correct. This seems like a poor design at this moment.

[Hawxy]

@BrechtLaitem I'd probably open up a separate issue just to track nullability problems. There's likely far more issues all over the place.