Support Default Editor Setting In Windows (#1454)

* feat(editor): implement platform-specific argument parsing for editors

- Added `parseEditorArgs` function for Windows and POSIX systems to handle command line arguments for text editors.
- Created `editor_windows.go` and `editor_unix.go` files to separate platform-specific implementations.
- Introduced tests in `editor_windows_test.go` and `editor_unix_test.go` to ensure correct parsing behavior across different scenarios.
- This change enhances compatibility with various text editors by correctly interpreting command line arguments, improving user experience.

* docs(README): update default editor instructions for Windows and macOS

- Clarified the default text editor settings for Linux/macOS and Windows.
- Added examples for setting the `EDITOR` environment variable in PowerShell and Command Prompt on Windows.
- Ensured instructions are clear for both terminal and non-terminal editors.

* docs(README): update default editor paths for Windows PowerShell

- Updated the Notepad++ and Visual Studio Code paths to a more generic format.

* docs(README): update default editor examples for Windows and Linux

- Included examples for using popular editors like Visual Studio Code and Sublime Text.
- Ensured consistency in formatting and improved clarity for users configuring their environment.

* refactor(editor_windows): simplify command line argument parsing

- Replaced custom argument parsing logic in `parseEditorArgs` with
  `windows.DecomposeCommandLine` for improved reliability and
  maintainability.
- Removed unnecessary error handling and conversions related to
  UTF-16 encoding, streamlining the function's implementation.

Author: bkiran6398

README.md

@@ -188,11 +188,11 @@ Select **y** to proceed with your default tenant, or **N** to choose a different
 
 ## Customization
 
-To change the text editor used for editing templates, rules, and actions, set the environment variable `EDITOR` to your
-preferred editor. If choosing a non-terminal editor, ensure that the command starts the editor and waits for the files
-to be closed before returning.
+The default text editor is `vim` on Linux/macOS and `notepad` on Windows. To change that for editing templates, rules, and actions, set the environment variable `EDITOR` to your
+preferred editor. If choosing a non-terminal editor, ensure that the command starts the editor and waits for the files to be closed before returning.
 
-Examples:
+### Examples:
+#### Linux / macOS
 
 ```shell
 # Uses vscode with the --wait flag.
@@ -208,6 +208,28 @@ export EDITOR="nano"
 export EDITOR="vim"
 ```
 
+#### Windows
+
+```powershell
+# PowerShell (current session):
+$env:EDITOR = "code --wait"
+$env:EDITOR = 'subl --wait'
+$env:EDITOR = 'notepad'
+$env:EDITOR = '"C:\Path To\executable++.exe" --wait'
+# PowerShell (persistent, across sessions):
+[System.Environment]::SetEnvironmentVariable("EDITOR", "code --wait", "User")
+```
+
+```cmd
+REM Command Prompt (current session):
+set EDITOR=code --wait
+set EDITOR=subl --wait
+set EDITOR=notepad
+set EDITOR="C:\Path To\executable++.exe" --wait
+REM Command Prompt (persistent, across sessions):
+setx EDITOR "code --wait"
+```
+
 ## Anonymized Analytics Disclosure
 
 Anonymized data points are collected during the use of this CLI. This data includes the CLI version, operating system, timestamp, and other technical details that do not personally identify you.

internal/prompt/editor.go

@@ -7,8 +7,6 @@ import (
 	"os/exec"
 	"runtime"
 
-	"github.com/kballard/go-shellquote"
-
 	"github.com/auth0/auth0-cli/internal/iostream"
 )
 
@@ -40,7 +38,7 @@ type editorPrompt struct {
 // openFile opens filename in the preferred text editor, resolving the
 // arguments with editor specific logic.
 func (p *editorPrompt) openFile(filename string, infoFn func()) error {
-	args, err := shellquote.Split(p.cmd)
+	args, err := parseEditorArgs(p.cmd)
 	if err != nil {
 		return err
 	}

internal/prompt/editor_unix.go

@@ -0,0 +1,14 @@
+//go:build !windows
+// +build !windows
+
+package prompt
+
+import (
+	"github.com/kballard/go-shellquote"
+)
+
+// parseEditorArgs parses POSIX shell-style command line arguments
+// into a slice of strings suitable for exec.Command.
+func parseEditorArgs(cmd string) ([]string, error) {
+	return shellquote.Split(cmd)
+}

internal/prompt/editor_unix_test.go

@@ -0,0 +1,73 @@
+//go:build !windows
+// +build !windows
+
+package prompt
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestParseEditorArgs(t *testing.T) {
+	tests := []struct {
+		name     string
+		cmd      string
+		expected []string
+		wantErr  bool
+	}{
+		{
+			name:     "simple editor",
+			cmd:      "vim",
+			expected: []string{"vim"},
+		},
+		{
+			name:     "editor with flag",
+			cmd:      "code --wait",
+			expected: []string{"code", "--wait"},
+		},
+		{
+			name:     "editor with multiple flags",
+			cmd:      "subl --wait --new-window",
+			expected: []string{"subl", "--wait", "--new-window"},
+		},
+		{
+			name:     "path with spaces in double quotes",
+			cmd:      `"/usr/local/bin/my editor" --wait`,
+			expected: []string{"/usr/local/bin/my editor", "--wait"},
+		},
+		{
+			name:     "path with spaces in single quotes",
+			cmd:      `'/usr/local/bin/my editor' --wait`,
+			expected: []string{"/usr/local/bin/my editor", "--wait"},
+		},
+		{
+			name:     "path without spoaces or quotes",
+			cmd:      `/usr/local/bin/myeditor --wait`,
+			expected: []string{"/usr/local/bin/myeditor", "--wait"},
+		},
+		{
+			name:     "empty command",
+			cmd:      ``,
+			expected: []string{},
+		},
+		{
+			name:    "unterminated quote",
+			cmd:     `"unterminated`,
+			wantErr: true,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			args, err := parseEditorArgs(tt.cmd)
+			if tt.wantErr {
+				require.Error(t, err)
+				return
+			}
+			require.NoError(t, err)
+			assert.Equal(t, tt.expected, args)
+		})
+	}
+}

internal/prompt/editor_windows.go

@@ -0,0 +1,12 @@
+//go:build windows
+// +build windows
+
+package prompt
+
+import (
+	"golang.org/x/sys/windows"
+)
+
+func parseEditorArgs(cmd string) ([]string, error) {
+	return windows.DecomposeCommandLine(cmd)
+}

internal/prompt/editor_windows_test.go

@@ -0,0 +1,68 @@
+//go:build windows
+// +build windows
+
+package prompt
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestParseEditorArgs(t *testing.T) {
+	tests := []struct {
+		name     string
+		cmd      string
+		expected []string
+		wantErr  bool
+	}{
+		{
+			name:     "simple editor",
+			cmd:      "notepad",
+			expected: []string{"notepad"},
+		},
+		{
+			name:     "editor with flag",
+			cmd:      "code --wait",
+			expected: []string{"code", "--wait"},
+		},
+		{
+			name:     "windows path with backslashes",
+			cmd:      `C:\Windows\notepad.exe`,
+			expected: []string{`C:\Windows\notepad.exe`},
+		},
+		{
+			name:     "quoted path with spaces",
+			cmd:      `"C:\Program Files\Notepad++\notepad++.exe" --wait`,
+			expected: []string{`C:\Program Files\Notepad++\notepad++.exe`, "--wait"},
+		},
+		{
+			name:     "quoted path with spaces and multiple flags",
+			cmd:      `"C:\Program Files\Microsoft VS Code\code.exe" --wait --new-window`,
+			expected: []string{`C:\Program Files\Microsoft VS Code\code.exe`, "--wait", "--new-window"},
+		},
+		{
+			name:     "path without spaces or quotes",
+			cmd:      `C:\tools\vim.exe -u C:\Users\me\.vimrc`,
+			expected: []string{`C:\tools\vim.exe`, "-u", `C:\Users\me\.vimrc`},
+		},
+		{
+			name:     "empty command",
+			cmd:      ``,
+			expected: []string{},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			args, err := parseEditorArgs(tt.cmd)
+			if tt.wantErr {
+				require.Error(t, err)
+				return
+			}
+			require.NoError(t, err)
+			assert.Equal(t, tt.expected, args)
+		})
+	}
+}