From ac359e2b50bc87de38c4a63333738bcb1d90e9f1 Mon Sep 17 00:00:00 2001 From: Alex Petenchea Date: Mon, 2 Mar 2026 15:06:10 +0800 Subject: [PATCH 1/2] Prevent failing test after compaction --- tests/test_collection.py | 31 +++++++++++++++++++++++++------ 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/tests/test_collection.py b/tests/test_collection.py index 0f0f2d3a..51ea8f41 100644 --- a/tests/test_collection.py +++ b/tests/test_collection.py @@ -1,3 +1,5 @@ +import time + import pytest from arango.client import ArangoClient @@ -196,13 +198,30 @@ def test_collection_management(db, bad_db, cluster): } ] - col = db.create_collection( - name=col_name, key_generator="autoincrement", key_increment=9, key_offset=100 + col = None + for _ in range(10): + try: + col = db.create_collection( + name=col_name, + key_generator="autoincrement", + key_increment=9, + key_offset=100, + ) + except CollectionCreateError: + print( + "Failed to create collection with autoincrement key generator," + "retrying..." + ) + time.sleep(3) + continue + key_options = col.properties()["key_options"] + assert key_options["key_generator"] == "autoincrement" + assert key_options["key_increment"] == 9 + assert key_options["key_offset"] == 100 + assert col is not None, ( + "Failed to create collection with autoincrement" + "key generator after multiple attempts" ) - key_options = col.properties()["key_options"] - assert key_options["key_generator"] == "autoincrement" - assert key_options["key_increment"] == 9 - assert key_options["key_offset"] == 100 col_name = generate_col_name() From a051565e86f6cbfe781724eb7d49e6fbe0f9bb83 Mon Sep 17 00:00:00 2001 From: Alex Petenchea Date: Mon, 2 Mar 2026 15:30:37 +0800 Subject: [PATCH 2/2] Fixed issues --- tests/test_collection.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/test_collection.py b/tests/test_collection.py index 51ea8f41..6ac6dcad 100644 --- a/tests/test_collection.py +++ b/tests/test_collection.py @@ -209,7 +209,7 @@ def test_collection_management(db, bad_db, cluster): ) except CollectionCreateError: print( - "Failed to create collection with autoincrement key generator," + "Failed to create collection with autoincrement key generator, " "retrying..." ) time.sleep(3) @@ -218,8 +218,9 @@ def test_collection_management(db, bad_db, cluster): assert key_options["key_generator"] == "autoincrement" assert key_options["key_increment"] == 9 assert key_options["key_offset"] == 100 + break assert col is not None, ( - "Failed to create collection with autoincrement" + "Failed to create collection with autoincrement " "key generator after multiple attempts" )