Skip to content

chore: Fix flaky test_allows_multiple_run_calls #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pijukatel merged 2 commits into from
Nov 20, 2025
Merged

chore: Fix flaky test_allows_multiple_run_calls #1573

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10ebd3d
Fix flaky `test_allows_multiple_run_calls`
Pijukatel Nov 19, 2025
c8b0a47
Remove redundant wait
Pijukatel Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions tests/unit/_autoscaling/test_autoscaled_pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,14 +310,14 @@ async def test_allows_multiple_run_calls(system_status: SystemStatus | Mock) ->
done_count = 0

async def run() -> None:
await asyncio.sleep(0.1)
nonlocal done_count
done_count += 1
await asyncio.sleep(0.1)

pool = AutoscaledPool(
system_status=system_status,
run_task_function=run,
is_task_ready_function=lambda: future(True),
is_task_ready_function=lambda: future(done_count < 4),
is_finished_function=lambda: future(done_count >= 4),
concurrency_settings=ConcurrencySettings(
min_concurrency=4,
Expand All @@ -330,8 +330,6 @@ async def run() -> None:
assert done_count == 4

done_count = 0
await asyncio.sleep(0.2) # Allow any lingering callbacks to complete
done_count = 0 # Reset again to ensure clean state

await pool.run()
assert done_count == 4