From 10ebd3d1bcb5c84126931f9c3166b886d3822bc5 Mon Sep 17 00:00:00 2001 From: Josef Prochazka Date: Wed, 19 Nov 2025 13:19:23 +0100 Subject: [PATCH 1/2] Fix flaky `test_allows_multiple_run_calls` --- tests/unit/_autoscaling/test_autoscaled_pool.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/unit/_autoscaling/test_autoscaled_pool.py b/tests/unit/_autoscaling/test_autoscaled_pool.py index 31e03cf73d..3df148c562 100644 --- a/tests/unit/_autoscaling/test_autoscaled_pool.py +++ b/tests/unit/_autoscaling/test_autoscaled_pool.py @@ -310,14 +310,14 @@ async def test_allows_multiple_run_calls(system_status: SystemStatus | Mock) -> done_count = 0 async def run() -> None: - await asyncio.sleep(0.1) nonlocal done_count done_count += 1 + await asyncio.sleep(0.1) pool = AutoscaledPool( system_status=system_status, run_task_function=run, - is_task_ready_function=lambda: future(True), + is_task_ready_function=lambda: future(done_count < 4), is_finished_function=lambda: future(done_count >= 4), concurrency_settings=ConcurrencySettings( min_concurrency=4, From c8b0a473165df8c00e9298b1ca5f0beae2847f22 Mon Sep 17 00:00:00 2001 From: Josef Prochazka Date: Wed, 19 Nov 2025 13:25:52 +0100 Subject: [PATCH 2/2] Remove redundant wait --- tests/unit/_autoscaling/test_autoscaled_pool.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/unit/_autoscaling/test_autoscaled_pool.py b/tests/unit/_autoscaling/test_autoscaled_pool.py index 3df148c562..fbe26319d8 100644 --- a/tests/unit/_autoscaling/test_autoscaled_pool.py +++ b/tests/unit/_autoscaling/test_autoscaled_pool.py @@ -330,8 +330,6 @@ async def run() -> None: assert done_count == 4 done_count = 0 - await asyncio.sleep(0.2) # Allow any lingering callbacks to complete - done_count = 0 # Reset again to ensure clean state await pool.run() assert done_count == 4