[MRRESOURCES-81] Unexpected behaviour when bundled resource has the same name as another file in src/main/resources

[jira-importer]

Falko Modler opened MRRESOURCES-81 and commented

Scenario:
Some project bundles a file named META-INF/beans.xml.
Another project wants to use that file for its tests, so it sets <attachToMain>false</attachToMain> and <attachToTest>true</attachToTest>. Now let's assume that this project also has a file named META-INF/beans.xml under src/main/resources.

My assumption - especially when using <attachToMain>false</attachToMain> - is that everything should be fine: the beans.xml from the bundle should not be conflicting with the one from the main branch of the project that wants to use the bundled file.

But this is what happens instead: The file from src/main/resources ends up in maven-shared-archive-resources, not the one from the bundle.

The problem is caused by the way existing project resources are seemingly preferred over the bundled resources from the user defined artifact (and are even copied to the output directory). From a user perspective, this is not what I want. See also ProcessRemoteResourcesMojo.copyResourceIfExists(...).

A possible fix might be to introduce a new property like preferProjectResources which can be set to false (which should be the default value in my opinion, would break backwards compatibility though).

---

Affects: 1.5

Attachments:

• MRRESOURCES-81.zip (7.95 kB)

[jira-importer]

Karl Heinz Marbaise commented

Could you create a sample project for what you like to expect or what you think is a bug?

[jira-importer]

Falko Modler commented

The attached zip file contains a maven project with two modules: bundle and process.

bundle packages a file named META-INF/beans.xml via maven-remote-resources-plugin (goal bundle).
process uses the bundle from above via maven-remote-resources-plugin (goal process). process also contains a META-INF/beans.xml in src/main/resources.

Simply call mvn clean install (or package) an you will see that MRRESOURCES81Test in process will fail.
The test expects the content of the class path resource /META-INF/beans.xml to be <\!-- from bundle \-\->, not <\!-- from process -->.

You can also see that the file in MRRESOURCES-81/process/target/maven-shared-archive-resource/META-INF is the one from process and not the one from bundle.

[jira-importer]

Karl Heinz Marbaise commented

First thanks for creating the example project.
The problem currently is based on that the maven-remote-resources-plugin will be executed during generate-resources phase where as the maven-resources-plugin is executed at process-resources which results in overwriting the bean.xml from maven-remote-resources-plugin. So from that point of view i don't see it as a bug, but it might be a good idea to reconsider if it would be possible to produce a warning in such situations.

[jira-importer]

Falko Modler commented

Well, it's the maven-remote-resources-plugin which copies the "wrong" beans.xml to maven-shared-archive-resource, not maven-resources-plugin. At least that's what I saw while debugging the process goal.

[jira-importer]

Michael Osipov commented

This issue has been auto closed because it has been inactive for a long period of time. If you think this issue still applies, retest your problem with the most recent version of Maven and the affected component, reopen and post your results.