Skip to content

Commit 08ca0b3

Browse files
committed
Follow up on #638 - fix pypi publish action version handling
The previous version (v1.12.4) should not have `keep: true` as it's not the newest version. Also updates README to better document the process of adding older vs newer versions of already approved actions. Generated-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 32f3c01 commit 08ca0b3

2 files changed

Lines changed: 15 additions & 2 deletions

File tree

README.md

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,11 +217,25 @@ If you need to add a specific version of an already approved action (especially
217217
```yaml
218218
existing/action:
219219
'<exact-commit-sha>':
220-
expires_at: 2025-01-01
221220
keep: true
222221
tag: vX.Y.Z
223222
```
224223

224+
if this is the newest version of the action (make sure to remove the `keep: true` from the
225+
previously newest version and add `expires_at: <date>` to it, if you want to set an expiration date for it),
226+
227+
or
228+
229+
```yaml
230+
existing/action:
231+
'<exact-commit-sha>':
232+
expires_at: 2025-01-01
233+
tag: vX.Y.Z
234+
```
235+
236+
If you add older version of the action and want to set an expiration date for it.
237+
238+
225239
3. **Create a PR** against the `main` branch
226240
4. **Include in your PR description**:
227241
- Specific reason why this version is required

actions.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -698,7 +698,6 @@ pypa/gh-action-pypi-publish:
698698
keep: true
699699
tag: v1.13.0
700700
76f52bc884231f62b9a034ebfe128415bbaabdfc:
701-
keep: true
702701
tag: v1.12.4
703702
expires_at: 2026-06-10
704703
pyTooling/Actions:

0 commit comments

Comments
 (0)