From 641e5330e05f346bdc69b00d65a2887ba7571ee6 Mon Sep 17 00:00:00 2001 From: Jack Dockerty Date: Thu, 5 Mar 2026 22:51:17 +0000 Subject: [PATCH 1/2] docs: expand with psql example --- crates/catalog/sql/src/lib.rs | 40 ++++++++++++++++++++++++++++++++++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/crates/catalog/sql/src/lib.rs b/crates/catalog/sql/src/lib.rs index b76006ed3b..fb8e95128b 100644 --- a/crates/catalog/sql/src/lib.rs +++ b/crates/catalog/sql/src/lib.rs @@ -18,7 +18,9 @@ //! Iceberg sql catalog implementation. //! //! To build a sql catalog with configurations -//! # Example +//! # Examples +//! +//! ## Generic //! //! ```rust, no_run //! use std::collections::HashMap; @@ -53,6 +55,42 @@ //! .unwrap(); //! } //! ``` +//! +//! ## Postgres +//! +//! ```rust, no_run +//! use std::collections::HashMap; +//! +//! use iceberg::CatalogBuilder; +//! use iceberg_catalog_sql::{ +//! SQL_CATALOG_PROP_BIND_STYLE, SQL_CATALOG_PROP_URI, SQL_CATALOG_PROP_WAREHOUSE, SqlBindStyle, +//! SqlCatalogBuilder, +//! }; +//! +//! #[tokio::main] +//! async fn main() { +//! let _catalog = SqlCatalogBuilder::default() +//! .load( +//! "postgres", +//! HashMap::from_iter([ +//! ( +//! SQL_CATALOG_PROP_URI.to_string(), +//! "postgres://iceberg:playground@localhost:5432".to_string(), +//! ), +//! ( +//! SQL_CATALOG_PROP_WAREHOUSE.to_string(), +//! "s3://localhost:9000".to_string(), +//! ), +//! ( +//! SQL_CATALOG_PROP_BIND_STYLE.to_string(), +//! SqlBindStyle::DollarNumeric.to_string(), +//! ), +//! ]), +//! ) +//! .await +//! .unwrap(); +//! } +//!``` #![deny(missing_docs)] From c1d488659a455f8542aa4ee389bddd66937615f5 Mon Sep 17 00:00:00 2001 From: Jack Dockerty Date: Fri, 6 Mar 2026 14:15:17 +0000 Subject: [PATCH 2/2] chore: fmt --- crates/catalog/sql/src/lib.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/catalog/sql/src/lib.rs b/crates/catalog/sql/src/lib.rs index fb8e95128b..eee9efd1d4 100644 --- a/crates/catalog/sql/src/lib.rs +++ b/crates/catalog/sql/src/lib.rs @@ -63,8 +63,8 @@ //! //! use iceberg::CatalogBuilder; //! use iceberg_catalog_sql::{ -//! SQL_CATALOG_PROP_BIND_STYLE, SQL_CATALOG_PROP_URI, SQL_CATALOG_PROP_WAREHOUSE, SqlBindStyle, -//! SqlCatalogBuilder, +//! SQL_CATALOG_PROP_BIND_STYLE, SQL_CATALOG_PROP_URI, SQL_CATALOG_PROP_WAREHOUSE, +//! SqlBindStyle, SqlCatalogBuilder, //! }; //! //! #[tokio::main] @@ -90,7 +90,7 @@ //! .await //! .unwrap(); //! } -//!``` +//! ``` #![deny(missing_docs)]