Variable and tunable support launch wizard#1698
Open
adedoyinNteligen wants to merge 1 commit into
Open
Conversation
scholarsmate
added
enhancement
There was a problem hiding this comment.
Pull request overview
Adds launch wizard support for editing Daffodil launch variables and tunables as key/value pairs, matching existing launch.json schema support.
Changes:
- Adds UI tables/buttons for variables and tunables in the launch wizard.
- Reads, renders, saves, and copies variable/tunable values through wizard scripting.
- Updates launch config typing and wiki documentation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 12 comments.
| File | Description |
|---|---|
src/launchWizard/script.js |
Adds table row handling, rendering, and save/copy integration for variables/tunables. |
src/launchWizard/launchWizard.ts |
Adds wizard HTML for variable/tunable sections. |
src/classes/vscode-launch.ts |
Adds optional variables and tunables fields to launch config args. |
doc/Wiki.md |
Documents variable/tunable wizard usage with screenshots. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adedoyinNteligen
force-pushed
the
variable-and-tunable-support-launch-wizard
branch
from
1980370 to
3d93191
Compare
…n the same manner adding variables Bump fast-xml-parser from 5.5.9 to 5.7.2 Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) from 5.5.9 to 5.7.2. - [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases) - [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md) - [Commits](NaturalIntelligence/fast-xml-parser@v5.5.9...v5.7.2) --- updated-dependencies: - dependency-name: fast-xml-parser dependency-version: 5.7.2 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Bump @vscode/vsce from 3.7.1 to 3.9.1 Bumps [@vscode/vsce](https://github.com/Microsoft/vsce) from 3.7.1 to 3.9.1. - [Release notes](https://github.com/Microsoft/vsce/releases) - [Commits](microsoft/vscode-vsce@v3.7.1...v3.9.1) --- updated-dependencies: - dependency-name: "@vscode/vsce" dependency-version: 3.9.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Bump actions/setup-node from 6.3.0 to 6.4.0 Bumps [actions/setup-node](https://github.com/actions/setup-node) from 6.3.0 to 6.4.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@53b8394...48b55a0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: 6.4.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Bump actions/github-script from 8.0.0 to 9.0.0 Bumps [actions/github-script](https://github.com/actions/github-script) from 8.0.0 to 9.0.0. - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@ed59741...3a2844b) --- updated-dependencies: - dependency-name: actions/github-script dependency-version: 9.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Changed wording in CI to match PR template Documentation Variable and Tunable Configuration Added sections on Variable and Tunable Configuration with usage instructions and references. Fix copy mechanism Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> copilot recommendations copilot recommendations copilot recs. Last one
adedoyinNteligen
force-pushed
the
variable-and-tunable-support-launch-wizard
branch
from
3d93191 to
1edc72a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1554
Description
This PR is adding the functionality to add tunables and variables to the launch.json through the wizard. There are Buttons to add new tunables and variables as key value pairs.
Wiki
[List added wiki/docs documentation here for review, if applicable]
Review Instructions including Screenshots
Below are screenshots of where to find the new configurable options
Confirmation Testing
[OPTIONAL: Describe the tests you performed to confirm that the change works as intended.
Include steps, commands, test data, or screenshots/GIFs as necessary.]
Regression Testing
[OPTIONAL: Describe any regression testing performed to ensure existing functionality was not broken.
List relevant test suites, manual checks, or validation steps.]