From 91ab7cd2b42dec96abb0a97bd7900a3e38a4083c Mon Sep 17 00:00:00 2001 From: Dewey Dunnington Date: Sun, 19 Apr 2026 21:35:47 -0500 Subject: [PATCH 1/2] set endianness of decoder --- src/nanoarrow/ipc/decoder_test.cc | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/nanoarrow/ipc/decoder_test.cc b/src/nanoarrow/ipc/decoder_test.cc index 2143b610a..4221ee5db 100644 --- a/src/nanoarrow/ipc/decoder_test.cc +++ b/src/nanoarrow/ipc/decoder_test.cc @@ -699,7 +699,7 @@ TEST(NanoarrowIpcTest, NanoarrowIpcDictionaryEncodingsUniqueIds) { ArrowIpcDictionaryEncodingsReset(&dictionary_encodings); } -TEST(NanoarrowIpcTest, NanoarrowIpcDecodeDictionaryBatchDecode) { +TEST(NanoarrowIpcTest, NanoarrowIpcDecodeDictionaryBatch) { using namespace nanoarrow::literals; struct ArrowIpcDictionaryEncodings dictionary_encodings; @@ -734,6 +734,14 @@ TEST(NanoarrowIpcTest, NanoarrowIpcDecodeDictionaryBatchDecode) { // Check that we can't decode a dictionary batch if we haven't read a dictionary batch // message ASSERT_EQ(ArrowIpcDecoderInit(&decoder), NANOARROW_OK); +#ifdef __BIG_ENDIAN__ + ASSERT_EQ(ArrowIpcDecoderSetEndianness(&decoder, NANOARROW_IPC_ENDIANNESS_LITTLE), + NANOARROW_OK); +#else + ASSERT_EQ(ArrowIpcDecoderSetEndianness(&decoder, NANOARROW_IPC_ENDIANNESS_BIG), + NANOARROW_OK); +#endif + struct ArrowBufferView body; body.data.data = nullptr; body.size_bytes = 0; From cf4403f992a361ddee752094f7ba6fca01394e6f Mon Sep 17 00:00:00 2001 From: Dewey Dunnington Date: Sun, 19 Apr 2026 22:12:42 -0500 Subject: [PATCH 2/2] whoops --- src/nanoarrow/ipc/decoder_test.cc | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/nanoarrow/ipc/decoder_test.cc b/src/nanoarrow/ipc/decoder_test.cc index 4221ee5db..48ed0af1f 100644 --- a/src/nanoarrow/ipc/decoder_test.cc +++ b/src/nanoarrow/ipc/decoder_test.cc @@ -734,13 +734,8 @@ TEST(NanoarrowIpcTest, NanoarrowIpcDecodeDictionaryBatch) { // Check that we can't decode a dictionary batch if we haven't read a dictionary batch // message ASSERT_EQ(ArrowIpcDecoderInit(&decoder), NANOARROW_OK); -#ifdef __BIG_ENDIAN__ ASSERT_EQ(ArrowIpcDecoderSetEndianness(&decoder, NANOARROW_IPC_ENDIANNESS_LITTLE), NANOARROW_OK); -#else - ASSERT_EQ(ArrowIpcDecoderSetEndianness(&decoder, NANOARROW_IPC_ENDIANNESS_BIG), - NANOARROW_OK); -#endif struct ArrowBufferView body; body.data.data = nullptr;