Skip to content

feat(apisix): Add namespace to manifest templates #949

@vramperez

Description

@vramperez

Context

Some manifest templates in the APISIX chart do not include namespace: {{ .Release.Namespace }}
in their metadata, for example:

This is inconsistent with Helm best practices, where templates should respect
the namespace provided during installation via --namespace or .Release.Namespace.

Expected behavior

All manifest templates should include:

metadata:
  namespace: {{ .Release.Namespace }}

Is this an intentional design decision?

If not, would a PR adding namespace: {{ .Release.Namespace }} to the affected
templates be welcome?

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions