Enhancement: Improve customizing: Bank Reconciliation Beta > Create Voucher > Journal Entry

[PatrickDEissler]

Issue: Add Context Flag to Journal Entries from Bank Reconciliation Tool Beta

In Bank Reconciliation Tool Beta (banking/klarna_kosma_integration/doctype/bank_reconciliation_tool_beta/unpaid_vouchers.py), the fields user_remark (User Remark) and cheque_no (Cheque No) are currently set on the created Journal Entry using values from the Bank Transaction.
PROBLEM: These fields are highly company-specific and may not consistently enable identifying or customizing these journal entries in custom integrations.

Case / Context

Whenever a bank transaction is processed, a Journal Entry is created. At this point, key fields like company, posting_date, cheque_date, cheque_no, title, and user_remark are passed from the bank transaction. However, there is no explicit way for custom apps to recognize journal entries that originate specifically from the Bank Reconciliation Tool Beta.

Suggestion for Improvement

Please add a flag or explicit field to hand over the Bank Transaction (ID) to the Journal Entry. This allows custom apps to use DocType hooks (such as before_insert) to detect and customize the handling of journal entries created during bank reconciliation, providing much more flexibility for company-specific workflows.

INTERNAL REF: IDM-342

[PatrickDEissler]

@barredterra
What do you think about that solution?

[barredterra]

How about:

def after_insert(doc: "JournalEntry", event):
	bank_transaction_id = frappe.db.ge_value(
		"Bank Transaction Payments",
		{"payment_document": "Journal Entry", "payment_entry": doc.name, "parenttype": "Bank Transaction"},
		"parent"
	)
	if bank_transaction_id:
		# your logic here

Your proposed solution would create a circular link chain, where Bank Transaction links to Journal Entry and Journal Entry in turn links to Bank Transaction. It's usually good to avoid this.

[PatrickDEissler]

Is this (frappe.db.get_value("Bank Transaction Payments" ...) known on before_insert?
I expected, that both the Bank Transaction Payment record and doc.name (naming not done yet!?) dont exist yet.

To my suggestion:
I suggest a flag, not a link field. Problem with the link field would be, that they are stronger connected (cancellation rules, deletion rules, ...).

[barredterra]

You're right, this would only work after_insert. I've updated my comment above.

A simple flag (in-memory) would be no problem, I guess. Just add journal_entry.flags.bank_transaction_name = bank_transaction_name above this line:

banking/banking/klarna_kosma_integration/doctype/bank_reconciliation_tool_beta/bank_reconciliation_tool_beta.py

Line 198 in e61ca2f

journal_entry.insert()