Skip to content

Commit fb4a628

Browse files
Albert Cansado SolàAlbert Cansado Solà
authored andcommitted
ensure checkbox has always a value
1 parent a511c3f commit fb4a628

1 file changed

Lines changed: 16 additions & 2 deletions

File tree

lib/class.generator_fields.php

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,21 @@ public static function get_fields_values($mod, $item_id, $params = array()) {
117117
self::$_fieldsvals[$tmp_id] = $fieldvals;
118118
if (isset($params['customfield'])) {
119119
foreach ($params['customfield'] as $fldid => $value) {
120-
$fieldvals[$fldid]['value'] = (empty($value) == true ? '' : (is_array($value) ? implode(',', $value) : $value));
120+
if (!isset($fieldvals[$fldid])) {
121+
continue;
122+
}
123+
124+
if ($fieldvals[$fldid]['type'] === 'checkbox') {
125+
$fieldvals[$fldid]['value'] = $value;
126+
} else {
127+
if (empty($value)) {
128+
$fieldvals[$fldid]['value'] = '';
129+
} else if (is_array($value)) {
130+
$fieldvals[$fldid]['value'] = implode(',', $value);
131+
} else {
132+
$fieldvals[$fldid]['value'] = $value;
133+
}
134+
}
121135
}
122136
}
123137

@@ -178,4 +192,4 @@ public static function alias_to_object($fielddefs, &$item) {
178192

179193
}
180194

181-
?>
195+
?>

0 commit comments

Comments
 (0)