web: modify tracing to get nicer span names

c-cube · c-cube · commit 37604d1790f2 · 2026-02-05T15:44:21.000-05:00
we don't need the full URL in the span name, these are supposed to be
low cardinality. The URL is already provided in attributes.
diff --git a/web.ml b/web.ml
@@ -302,7 +302,7 @@ module Http (IO : IO_TYPE) (Curl_IO : CURL with type 'a t = 'a IO.t) : HTTP with
       ]
     in
     let explicit_span =
-      let span_name = Printf.sprintf "%s %s" action_name url in
+      let span_name = Printf.sprintf "devkit.web.%s" action_name in
       (* We set the value of `__FUNCTION__` to preserve the build with OCaml < 4.12. *)
       Possibly_otel.enter_manual_span
         ~__FUNCTION__:"Devkit.Web.Http.http_request'" ~__FILE__ ~__LINE__ ~data:describe span_name in

Original file line number	Diff line number	Diff line change
`@@ -302,7 +302,7 @@ module Http (IO : IO_TYPE) (Curl_IO : CURL with type 'a t = 'a IO.t) : HTTP with`
`302`	`302`	`]`
`303`	`303`	`in`
`304`	`304`	`let explicit_span =`
`305`		`- let span_name = Printf.sprintf "%s %s" action_name url in`
	`305`	`+ let span_name = Printf.sprintf "devkit.web.%s" action_name in`
`306`	`306`	(* We set the value of `__FUNCTION__` to preserve the build with OCaml < 4.12. *)
`307`	`307`	`Possibly_otel.enter_manual_span`
`308`	`308`	`~__FUNCTION__:"Devkit.Web.Http.http_request'" ~__FILE__ ~__LINE__ ~data:describe span_name in`