Skip to content

Critical client and runtime paths remain under-tested despite total coverage exceeding 80 percent #61

@nficano

Description

@nficano

The measured aggregate coverage is above the requested threshold, with 83.39% region coverage and 83.92% line coverage from cargo-llvm-cov. The uncovered areas are concentrated in the paths most likely to hide behavioral regressions: src/client/api.rs is at 70.24% line coverage, src/runtime/server.rs is at 70.38%, src/runtime/credentials.rs is at 73.18%, src/runtime/job.rs is at 78.17%, src/transport/stdio.rs is at 69.23%, and src/transport/websocket.rs is at 72.41%. The missing tests line up with the high-risk findings above, including pending client operations on close, cross-session cancel authorization, ack-window shutdown, durable job disconnect behavior, event sequencing, idempotency, and budget boundary behavior.

Fix prompt: Add focused regression tests around the low-coverage critical paths rather than broad snapshot tests. Cover client pending request cleanup for invoke, artifact APIs, and subscribe; runtime authorization for cancel and job subscriptions; ack-window shutdown when the peer disconnects; durable job behavior after transport close; exact budget exhaustion boundaries; and idempotency-key retries across connections. Keep the cargo-llvm-cov gate at or above 80% for both line and region coverage and consider adding per-file expectations for client/api.rs and runtime/server.rs once those edge cases are covered.

Metadata

Metadata

Assignees

No one assigned

    Labels

    severity:mediumMedium severity issuetestingAutomated test coverage and regression tests

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions