-
Notifications
You must be signed in to change notification settings - Fork 50
docs: clarify kind prereqs and fix stale install-script references #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -87,7 +87,10 @@ goals in the near term. | |
|
|
||
| To quickly set up the complete environment: | ||
|
|
||
| 1. Make sure you have [`kind`](https://kind.sigs.k8s.io/), [`kubectl`](https://kubernetes.io/docs/tasks/tools/), and [`docker`](https://www.docker.com/) installed and configured on your dev machine. | ||
| 1. Make sure the following tools are installed and configured on your development machine: | ||
| - [`kind`](https://kind.sigs.k8s.io/) **v0.31.0 or newer** (required for the `PodCertificateRequest` API the install scripts use; matches the CI-pinned `go install sigs.k8s.io/kind@v0.31.0`). | ||
| - [`kubectl`](https://kubernetes.io/docs/tasks/tools/). | ||
| - [`docker`](https://www.docker.com/) with **at least 12 GiB of memory** allocated to the VM (Docker Desktop: Settings → Resources → Memory). | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. are we using 12GiB? must be the image cache ... we're going to need to think about tiers there
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 12 seemed to work :) i did not try going lower
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm OK, I want to avoid overstating it if we can, this is also likely going to be very fluid as we iterate, most of it is probably various in-memory storage currently that doesn't strictly need to all be in memory in the future ... |
||
|
|
||
| 2. Run the following steps: | ||
| ```shell | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not required or used anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benjamin Elder (@BenTheElder) we still use (
substrate/.github/workflows/pr-workflow.yaml
Line 42 in 2f2292f
should we reflect that? (and drop the note about
PodCertificateRequestAPI)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you DIY install we don't inherently depend on kind, but our dev scripts will depend on the version in the tools module in the future, I think we don't need to specify the version here. Thanks.
I also think we will stop depending on the default node image in the future, but I want to ship some upstream kind fixes first.