Add a way to ignore app-specific exceptions

[marcuspoehls]

The exception handler provides the ignoreExceptions attribute with pre-defined exceptions: https://github.com/adonisjs/http-server/blob/7.x/src/exception_handler.ts#L64-L69

  protected ignoreExceptions: any[] = [
    errors.E_HTTP_EXCEPTION,
    errors.E_ROUTE_NOT_FOUND,
    errors.E_CANNOT_LOOKUP_ROUTE,
    errors.E_HTTP_REQUEST_ABORTED,
  ]

There’s currently no way to define user-land exceptions that can be ignored. I’m not seeing how I could reuse the ignoreExceptions property and keep the default values assigned, plus adding my own ones.

That’s why I’m suggesting adding a property that can be used for app-specific exceptions.

I’m currently using the ignoreCodes property, which has no default values. But as soon as the framework adds default values here too, I’m in the same situation as above. Also, I can’t ignore an exception by code if an exception doesn’t provide a static code attribute.

Maybe there’s already a way to do what I’m asking for 🙂 if there is, please point me to it

[thetutlage]

Yeah, there could be many ways. The one that will work right now is the following.

  constructor() {
    super()
    this.ignoreExceptions = [...this.ignoreExceptions]
  }

[marcuspoehls]

Thank you! Good idea.

I’m printing the picture for everything to follow my thoughts here:

Option 1

We can add the ignored exceptions in the array assigned to ignoreExceptions in the constructor like this:

  constructor() {
    super()

    this.ignoreExceptions = [
      ...this.ignoreExceptions, // the ignoreExceptions coming from the framework
      MyExceptionClass1,
      MyExceptionClass2,
    ]
  }

Option 2

We can use our own exception handler class property and merge them like this:

  constructor () {
    super()

    this.ignoreExceptions = [
      ...this.ignoreExceptions,
      ...this.notReportedExceptions,
    ]
  }

  protected notReportedExceptions: any[] = [
    MyExceptionClass1,
    MyExceptionClass2,
  ]

Thank you Harminder, for sparking ideas on the direction!

If you think it’s a good idea to add an option for user-land exceptions, I would leave this issue open. Otherwise I’ll close it after you’ve answered 🙂

[github-actions]

This issue has been marked as stale because it has been inactive for more than 21 days. Please reopen if you still need help on this issue