Skip to content

fix: clean up test quality issues found in code review #35

@vdua

Description

@vdua

Problem

A code review of the test suite identified the following issues:

1. Debug console.log left in committed test

File: tests/e2e/error-dashboard.spec.js line 120

console.log('buildDashboardURL', buildDashboardURL({ ...baseParams(), url: '' }));

Should be removed.

2. Fragile waitForTimeout usage (2 places)

  • tests/e2e/domain-config.spec.js line 48 — await page.waitForTimeout(2000)
  • tests/e2e/error-dashboard.spec.js line 173 — await page.waitForTimeout(2000)

These are flaky under slow CI. Should be replaced with explicit waitForSelector or waitForFunction conditions.

Acceptance Criteria

  • Remove console.log from error-dashboard.spec.js
  • Replace waitForTimeout(2000) in domain-config.spec.js with a deterministic wait
  • Replace waitForTimeout(2000) in error-dashboard.spec.js with a deterministic wait
  • All E2E tests pass after changes

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions