Problem
A code review of the test suite identified the following issues:
1. Debug console.log left in committed test
File: tests/e2e/error-dashboard.spec.js line 120
console.log('buildDashboardURL', buildDashboardURL({ ...baseParams(), url: '' }));
Should be removed.
2. Fragile waitForTimeout usage (2 places)
tests/e2e/domain-config.spec.js line 48 — await page.waitForTimeout(2000)
tests/e2e/error-dashboard.spec.js line 173 — await page.waitForTimeout(2000)
These are flaky under slow CI. Should be replaced with explicit waitForSelector or waitForFunction conditions.
Acceptance Criteria
Problem
A code review of the test suite identified the following issues:
1. Debug
console.logleft in committed testFile:
tests/e2e/error-dashboard.spec.jsline 120Should be removed.
2. Fragile
waitForTimeoutusage (2 places)tests/e2e/domain-config.spec.jsline 48 —await page.waitForTimeout(2000)tests/e2e/error-dashboard.spec.jsline 173 —await page.waitForTimeout(2000)These are flaky under slow CI. Should be replaced with explicit
waitForSelectororwaitForFunctionconditions.Acceptance Criteria
console.logfromerror-dashboard.spec.jswaitForTimeout(2000)indomain-config.spec.jswith a deterministic waitwaitForTimeout(2000)inerror-dashboard.spec.jswith a deterministic wait