Refactor config loading and clean up code

Simplified the Bangla ordinal suffix match in bangla_date.rs. Refactored Config::load in config.rs to use let-chains for cleaner logic. Updated screensaver.rs to use a const thread-local buffer and improved ScreensaverMode argument handling. Fixed button style casting and added a clippy allow in settings.rs. Removed the unused build.ps1 script.

Author: abusayed0206

build.ps1

@@ -50,10 +50,7 @@ fn get_bangla_ordinal_suffix(day: u8) -> &'static str {
         1 => "লা",
         2 | 3 => "রা",
         4 => "ঠা",
-        5 | 6 => "ই",
-        7 => "ই",
-        8 | 9 | 10 => "ই",
-        11 | 12 => "ই",
+        5..=12 => "ই",
         _ => "ই",
     }
 }

src/bangla_date.rs

@@ -162,14 +162,12 @@ impl Config {
 
     /// Load configuration from file, or create default if not exists
     pub fn load() -> Self {
-        if let Some(path) = Self::config_path() {
-            if path.exists() {
-                if let Ok(content) = fs::read_to_string(&path) {
-                    if let Ok(config) = serde_json::from_str(&content) {
-                        return config;
-                    }
-                }
-            }
+        if let Some(path) = Self::config_path()
+            && path.exists()
+            && let Ok(content) = fs::read_to_string(&path)
+            && let Ok(config) = serde_json::from_str(&content)
+        {
+            return config;
         }
         let config = Self::default();
         config.save(); // Save default config

src/config.rs

@@ -30,7 +30,7 @@ static RENDERER: OnceLock<Mutex<Renderer>> = OnceLock::new();
 
 // Thread-local buffer for rendering to avoid per-frame allocations
 thread_local! {
-    static RENDER_BUFFER: RefCell<Vec<u8>> = RefCell::new(Vec::new());
+    static RENDER_BUFFER: RefCell<Vec<u8>> = const { RefCell::new(Vec::new()) };
 }
 
 /// Screensaver operating mode
@@ -74,9 +74,8 @@ impl ScreensaverMode {
                 0
             };
             ScreensaverMode::Preview(hwnd)
-        } else if arg.starts_with("/s") || arg.starts_with("-s") {
-            ScreensaverMode::Screensaver
         } else {
+            // Default to Screensaver mode for /s, -s, or any other argument
             ScreensaverMode::Screensaver
         }
     }
@@ -304,7 +303,7 @@ fn render_clock_content(dc: HDC, width: u32, height: u32) {
         }
 
         // Calculate total content height for vertical centering
-        let time_height = (time_font_size * 1.3) as f32;
+        let time_height = time_font_size * 1.3;
         let mut total_height = time_height;
 
         if config.show_time_period {

src/screensaver.rs

@@ -240,7 +240,7 @@ fn create_settings_controls(hwnd: HWND) {
             .encode_utf16()
             .chain(std::iter::once(0))
             .collect();
-        let btn_style = WS_CHILD | WS_VISIBLE | WINDOW_STYLE(BS_PUSHBUTTON as u32);
+        let btn_style = WS_CHILD | WS_VISIBLE | WINDOW_STYLE(BS_PUSHBUTTON);
         let _ = CreateWindowExW(
             WINDOW_EX_STYLE::default(),
             w!("BUTTON"),
@@ -293,6 +293,7 @@ fn create_settings_controls(hwnd: HWND) {
 }
 
 /// Create a toggle button with ON/OFF indicator
+#[allow(clippy::too_many_arguments)]
 fn create_toggle_button(
     hwnd: HWND,
     instance: HINSTANCE,
@@ -313,7 +314,7 @@ fn create_toggle_button(
             WINDOW_EX_STYLE::default(),
             w!("BUTTON"),
             PCWSTR(text_wide.as_ptr()),
-            WS_CHILD | WS_VISIBLE | WINDOW_STYLE(BS_PUSHBUTTON as u32 | BS_LEFT as u32),
+            WS_CHILD | WS_VISIBLE | WINDOW_STYLE(BS_PUSHBUTTON | BS_LEFT),
             x,
             y,
             width,