Things to do before Sunday 11:59 p.m.

[RobinPetit]

Issue by TheoVerhelst
Saturday Mar 26, 2016 at 16:00 GMT
Originally opened as https://github.com/ulb-infof209/Group5/issues/154

---

• Reactivate the password checking in the server;
• Deactivate the loop-based port checking in the client (as Robin said, this is really not a consistent feature for deployment);
• Go through ALL of the "TODO"s in the code and do them; (<= Haha!!)
• Remember deck modifications;
• Merge all branches into master;
• Compile the last version of the code for the NO4 by linking statically SFML and TGUI;
• Update the SRD;

[RobinPetit]

Comment by RobinPetit
Saturday Mar 26, 2016 at 16:13 GMT

---

First, good initiative!

For the second point, we can put a violent

#ifdef NDEBUG
    // connect directly and screw you if it is impossible
#else
    // have the loop and try/catch
#endif

And then this could go the the AbstractHomeState.

[RobinPetit]

Comment by areynoua
Saturday Mar 26, 2016 at 18:20 GMT

---

and write the SRD

[RobinPetit]

Comment by TheoVerhelst
Saturday Mar 26, 2016 at 19:17 GMT

---

I implemented the conditional compilation of the ports testing. I've done this in ImplementationGuiGame by mistake, but I don't think that will cause any conflict, the HomeStates are not that much modified by the branches we'll have to merge.

[RobinPetit]

Comment by RobinPetit
Saturday Mar 26, 2016 at 22:46 GMT

---

Let's have @NBaudoux or @Amuranov on the SRD maybe?

[RobinPetit]

Comment by Amuranov
Saturday Mar 26, 2016 at 22:48 GMT

---

What should we add to the srd ?

[RobinPetit]

Comment by RobinPetit
Saturday Mar 26, 2016 at 22:49 GMT

---

I don't know exactly but I know we have an issue (#90) about something to update.

[RobinPetit]

Comment by TheoVerhelst
Saturday Mar 26, 2016 at 22:53 GMT

---

Well, I explained the main design of the game to Nicolas (such as the *State classes and the network protocol), he should be able to write many things about that.

[RobinPetit]

Comment by StanIsAdmin
Sunday Mar 27, 2016 at 18:04 GMT

---

Well I'm sure he's making very good use of all that information 😠