From 5d0005ec321579c04c50a8347177b7446fdc80d5 Mon Sep 17 00:00:00 2001
From: Keith Miller <keith_miller@apple.com>
Date: Fri, 11 Jul 2025 08:39:22 -0400
Subject: [PATCH] Move prepareForNextIteration call from Benchmark's runnerCode
 to preIterationCode

This makes it easier for Benchmark subclasses to also call. This fixes a bug in https://github.com/WebKit/JetStream/pull/74
which caused inspector code load benchmarks to not set up properly ending the benchmark in 0ms.

Also, use optional chaining for the call (and few other similar optional helpers).
---
 JetStreamDriver.js | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/JetStreamDriver.js b/JetStreamDriver.js
index 581a3335..1712b9db 100644
--- a/JetStreamDriver.js
+++ b/JetStreamDriver.js
@@ -650,9 +650,6 @@ class Benchmark {
             let benchmarkName = "${this.name}";
 
             for (let i = 0; i < ${this.iterations}; i++) {
-                if (__benchmark.prepareForNextIteration)
-                    __benchmark.prepareForNextIteration();
-
                 ${this.preIterationCode}
 
                 const iterationMarkLabel = benchmarkName + "-iteration-" + i;
@@ -668,8 +665,7 @@ class Benchmark {
 
                 results.push(Math.max(1, end - start));
             }
-            if (__benchmark.validate)
-                __benchmark.validate(${this.iterations});
+            __benchmark.validate?.(${this.iterations});
             top.currentResolve(results);`;
     }
 
@@ -684,7 +680,7 @@ class Benchmark {
     get prerunCode() { return null; }
 
     get preIterationCode() {
-        let code = "";
+        let code = `__benchmark.prepareForNextIteration?.();`;
         if (this.plan.deterministicRandom)
             code += `Math.random.__resetSeed();`;
 
@@ -1185,8 +1181,7 @@ class AsyncBenchmark extends DefaultBenchmark {
         return `
         async function doRun() {
             let __benchmark = new Benchmark();
-            if (__benchmark.init)
-                await __benchmark.init();
+            await __benchmark.init?.();
             let results = [];
             let benchmarkName = "${this.name}";
 
@@ -1206,8 +1201,7 @@ class AsyncBenchmark extends DefaultBenchmark {
 
                 results.push(Math.max(1, end - start));
             }
-            if (__benchmark.validate)
-                __benchmark.validate(${this.iterations});
+            __benchmark.validate?.(${this.iterations});
             top.currentResolve(results);
         }
         doRun().catch((error) => { top.currentReject(error); });`