Skip to content

StartupBenchmark: add better assertion messages #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camillobruni merged 1 commit into from
Aug 26, 2025
Merged

StartupBenchmark: add better assertion messages #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions startup-helper/StartupBenchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,20 @@ class StartupBenchmark {
expectedCacheCommentCount,
sourceCodeReuseCount = 1,
} = {}) {
console.assert(iterationCount > 0);
console.assert(
iterationCount > 0,
`Expected iterationCount to be positive, but got ${iterationCount}`
);
this.#iterationCount = iterationCount;
console.assert(expectedCacheCommentCount > 0);
console.assert(
expectedCacheCommentCount > 0,
`Expected expectedCacheCommentCount to be positive, but got ${expectedCacheCommentCount}`
);
this.#expectedCacheCommentCount = expectedCacheCommentCount;
console.assert(sourceCodeReuseCount >= 0);
console.assert(
sourceCodeReuseCount >= 0,
`Expected sourceCodeReuseCount to be non-negative, but got ${sourceCodeReuseCount}`
);
this.#sourceCodeReuseCount = sourceCodeReuseCount;
}

Expand Down
Loading