There are some confusing / unclear parameter names in the source code. For example:
final case class DependencyProvider(
intelliJ: IntelliJDependencyProvider,
plugin: PluginDependencyProvider,
jbr: JbrDependencyProvider
)
Where we have plugin: PluginDependencyProvider and later on we have following method call in the code:
val file = dependencies.plugin.fetch(plugin)
Where first plugin refers to the PluginDependencyProvider type and second one to an object of Plugin type. There are more cases like this one. We should rename such fields / parameters for better code readability.
There are some confusing / unclear parameter names in the source code. For example:
Where we have
plugin: PluginDependencyProviderand later on we have following method call in the code:val file = dependencies.plugin.fetch(plugin)Where first
pluginrefers to thePluginDependencyProvidertype and second one to an object ofPlugintype. There are more cases like this one. We should rename such fields / parameters for better code readability.