The arms holding HBM's NTM guns phase through Flan's Mod armors

[Bu0ngiorno]

The arms holding HBM's NTM guns phase through Flan's Mod armors (i don't have a screenshot right now unfortunately).

I talked to the author (HBM) about this issue and he says it's because of FMUSE:

Is it possible that it could be because of the fix about the cloth/leather type issue? (Like i said in one of the screenshots) The guns work fine on other armors though.

[GoldSloth]

Hi, could you get me some sreenshots/video of this please?

NTM probably overrides the drawing of the arm - but Flansmod armour draws the armour around where it expects the arm to be, that's my guess and I can't be 100% sure.
This probably isn't easy to fix. It's almost certainly unrelated to the cloth/leather armour thing too.

[Bu0ngiorno]

Yes, here's a screenshot (the armor is from W44 but this is with every Flan's Mod armor:

(This issue is also with NTM akimbo guns)

NTM & Flan's Mod Armors are normal with Flan's Mod guns:

[GoldSloth]

I'm not really sure - I think it depends how HBM is dealing with the arms in the first place.

This is the code for flansmod armour, which is a pretty thin layer over the top of the vanilla armour rendering.
https://github.com/Unknown025/Flans-Mod-Plus/blob/Ultimate/src/main/java/com/flansmod/client/model/ModelCustomArmour.java

Aside from that, I think Flansmod does change the arm positioning, but only when Flansmod guns are held.

So, I'm not really sure sorry - compatibility with other mods is quite difficult because you have to understand both mods.

[Bu0ngiorno]

Here's an update from Bobcat:

[GoldSloth]

FlansMod overrides aimedBow and then sets it if the action of the item you're holding is a bow.

https://github.com/Unknown025/Flans-Mod-Plus/blob/Ultimate/src/main/java/com/flansmod/client/model/ModelCustomArmour.java#L37

So if ntm has it's gun as EnumAction bow it might work? Otherwise we could make it respect aimedBow if it's been set before render.

[Bu0ngiorno]

Update:

[GoldSloth]

As far as I can see, Flansmod armour is copying the vanilla armour positions. All the code is doing in that file is reading the positions and rendering the MRT model groups according to those positions/rotations.

What appears to be the issue there is setting aimedBow=false by default, unless the enumaction is bow - which it isn't in NTM.

Changing that to respect the value set already may fix this issue. I'll see if I've got time to make a test build for you with that change.

[GoldSloth]

Apologies it's taken me a while to get to, I've not touched the armour stuff before so learning how it all works.

I've done a bit of digging, and I've changed the code so if you set aimedBow=true on renderPassModel from RenderPlayer, it might work. (Mirrored setting aimedBow=false after rendering, so if you override the value in RenderPlayerEvent.Pre it should respect that). Setting aimedBow on modelArmour or modelBipedMain or modelArmorChestplate won't work I think - reasons below.

I've compiled the change to test:
Test build.zip

The gist of RenderPlayer:138 (doRender) is:

// set aimedBow on.. something?
net.minecraftforge.client.event.RenderPlayerEvent.Pre(...)

...

if (itemInUseCount() > 0 {
    if (enumActions == EnumAction.Bow) {
// Set aimedBow
        this.modelArmorChestplate.aimedBow = this.modelArmor.aimedBow = this.modelBipedMain.aimedBow = true;
    }

...
}

...
// Render using set value of aimedBow
super.doRender((EntityLivingBase)p_76986_1_, p_76986_2_, d3, p_76986_6_, p_76986_8_, p_76986_9_);
// Reset aimedBow to false
this.modelArmorChestplate.aimedBow = this.modelArmor.aimedBow = this.modelBipedMain.aimedBow = false;

The thing's that get rendered by doRender are renderPassModel or mainModel. This gets chosen in RenderPlayer:52 (ShouldRenderPass) which calls ForgeHooksClient:311, calling getArmorModel on the armour item. If this is null it resorts to modelArmor or modelArmorChestplate.

As seen in the above code modelArmor and modelArmorChestplate have aimedBow set automatically based on enumAction. But, there's nothing to set that state in ModelCustomArmour/renderPassModel.

If you're suggesting you can get the state from mainModel/modelArmor/modelBipedMain into renderPassModel, I'd be interested to hear how. I can't really see an easy way in without overriding a bunch of stuff.

Also, feel free to add me on discord to talk more directly if you'd like. my tag is goldsloth on there, discord invite is in our readme.

[Bu0ngiorno]

Thanks! I will try it out when i have time, then i will update you later.

As for the Discord invite, sure, i'll look into it.

[Bu0ngiorno]

It still doesn't work for me, i used the build you gave me.

But a funny thing that i've noticed is that CustomNPC's don't have this problem with NTM guns while wearing Flan's armors.

[GoldSloth]

Hey thanks for trying that out, I thought this would happen - it needs some changes on HBMs end, a unless there's some other way of handling armour that I'm not aware of. (As it's setting aimedBow on a different armour instance, not the one being rendered)