From 685d6c1136f96444a794a3a95fc10e1a400598d9 Mon Sep 17 00:00:00 2001 From: Merlin Beutlberger Date: Fri, 22 May 2026 14:08:35 +0200 Subject: [PATCH 1/2] refactor(server): Fix dead branch in addCustomMiddleware The early-return check `!projectCustomMiddleware.length === 0` parses as `(!length) === 0`, which is always false for both empty and non-empty arrays. The branch never fired, but the for-loop below already handles empty arrays as a no-op, so behavior was unchanged. Initially found by @EdrilanBerisha in https://github.com/UI5/cli/pull/1391 --- packages/server/lib/middleware/MiddlewareManager.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/server/lib/middleware/MiddlewareManager.js b/packages/server/lib/middleware/MiddlewareManager.js index 36894892e4d..ad8ebbea151 100644 --- a/packages/server/lib/middleware/MiddlewareManager.js +++ b/packages/server/lib/middleware/MiddlewareManager.js @@ -245,7 +245,7 @@ class MiddlewareManager { async addCustomMiddleware() { const project = this.graph.getRoot(); const projectCustomMiddleware = project.getCustomMiddleware(); - if (!projectCustomMiddleware.length === 0) { + if (projectCustomMiddleware.length === 0) { return; // No custom middleware defined } From 3d4ddaf1adb41bfa0002b5cb6ea73ff7da9405f8 Mon Sep 17 00:00:00 2001 From: Merlin Beutlberger Date: Fri, 22 May 2026 14:08:57 +0200 Subject: [PATCH 2/2] refactor(builder): Add message to SapUiDefineCall TypeError The TypeError thrown when a sap.ui.define dependency element is not a string literal had no message, leaving no context when the build failed on malformed input. --- packages/builder/lib/lbt/calls/SapUiDefine.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/builder/lib/lbt/calls/SapUiDefine.js b/packages/builder/lib/lbt/calls/SapUiDefine.js index 0bf1c515e2f..ad9dac794bb 100644 --- a/packages/builder/lib/lbt/calls/SapUiDefine.js +++ b/packages/builder/lib/lbt/calls/SapUiDefine.js @@ -39,7 +39,7 @@ class SapUiDefineCall { this.dependencies = this.dependencyArray.elements.map( (elem) => { const value = getStringValue(elem); if ( !value ) { - throw new TypeError(); + throw new TypeError(`dependency element is not a string literal in module ${this.name}`); } return resolveRelativeRequireJSName(this.name, value); });