fix: Clicking comment overlapping link opens link (BLO-1091) #7601
matthewlipskibuild.yml
on: pull_request
Playwright Build
2m 31s
Build
3m 54s
Matrix: playwright
Merge Playwright Reports
56s
Annotations
7 errors, 2 warnings, and 5 notices
|
Playwright Tests - firefox (2/2)
Value cannot be null. (Parameter 'ContainerId')
|
|
Playwright Tests - firefox (2/2)
Value cannot be null. (Parameter 'ContainerId')
|
|
Playwright Tests - firefox (2/2)
Docker pull failed with exit code 1
|
|
Build
Process completed with exit code 1.
|
|
src/prosemirror/agent.test.ts > agentStepToTr > Update > drop mark and link and change text within mark:
packages/xl-ai/src/prosemirror/agent.test.ts#L260
Error: Snapshot `agentStepToTr > Update > drop mark and link and change text within mark 1` mismatched
- Expected
+ Received
@@ -10,7 +10,7 @@
"I {"type":"doc","content":[{"type":"blockGroup","content":[{"type":"blockContainer","attrs":{"id":"ref1"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world!"}]}]},{"type":"blockContainer","attrs":{"id":"ref2"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, "},{"type":"mention","attrs":{"user":"John Doe"}},{"type":"text","text":"! "},{"type":"text","marks":[{"type":"bold"}],"text":"How are you doing?"},{"type":"text","text":" "},{"type":"text","marks":[{"type":"textColor","attrs":{"stringValue":"blue"}}],"text":"This text is blue!"}]}]},{"type":"blockContainer","attrs":{"id":"ref3"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","marks":[{"type":"deletion","attrs":{"id":null}}],"text":"Hello"},{"type":"text","marks":[{"type":"insertion","attrs":{"id":null}}],"text":"Hi"},{"type":"text","text":", world! "},{"type":"text","marks":[{"type":"bold"},{"type":"deletion","attrs":{"id":null}}],"text":"Bold"},{"type":"text","marks":[{"type":"insertion","attrs":{"id":null}}],"text":"Bold th"},{"type":"text","marks":[{"type":"bold"}],"text":" text. "},{"type":"text","marks":[{"type":"link","attrs":{"href":"https://www.google.com"}}],"text":"Link."}]}]}]}]}",
"I {"type":"doc","content":[{"type":"blockGroup","content":[{"type":"blockContainer","attrs":{"id":"ref1"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world!"}]}]},{"type":"blockContainer","attrs":{"id":"ref2"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, "},{"type":"mention","attrs":{"user":"John Doe"}},{"type":"text","text":"! "},{"type":"text","marks":[{"type":"bold"}],"text":"How are you doing?"},{"type":"text","text":" "},{"type":"text","marks":[{"type":"textColor","attrs":{"stringValue":"blue"}}],"text":"This text is blue!"}]}]},{"type":"blockContainer","attrs":{"id":"ref3"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","marks":[{"type":"deletion","attrs":{"id":null}}],"text":"Hello"},{"type":"text","marks":[{"type":"insertion","attrs":{"id":null}}],"text":"Hi"},{"type":"text","text":", world! "},{"type":"text","marks":[{"type":"bold"},{"type":"deletion","attrs":{"id":null}}],"text":"Bold"},{"type":"text","marks":[{"type":"insertion","attrs":{"id":null}}],"text":"Bold the"},{"type":"text","marks":[{"type":"bold"}],"text":" text. "},{"type":"text","marks":[{"type":"link","attrs":{"href":"https://www.google.com"}}],"text":"Link."}]}]}]}]}",
"S {"type":"doc","content":[{"type":"blockGroup","content":[{"type":"blockContainer","attrs":{"id":"ref1"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world!"}]}]},{"type":"blockContainer","attrs":{"id":"ref2"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, "},{"type":"mention","attrs":{"user":"John Doe"}},{"type":"text","text":"! "},{"type":"text","marks":[{"type":"bold"}],"text":"How are you doing?"},{"type":"text","text":" "},{"type":"text","marks":[{"type":"textColor","attrs":{"stringValue":"blue"}}],"text":"This text is blue!"}]}]},{"type":"blockContainer","attrs":{"id":"ref3"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","marks":[{"type":"deletion","attrs"
|
|
src/prosemirror/agent.test.ts > agentStepToTr > Update > drop mark and link:
packages/xl-ai/src/prosemirror/agent.test.ts#L260
Error: Snapshot `agentStepToTr > Update > drop mark and link 1` mismatched
- Expected
+ Received
[
"S {"type":"doc","content":[{"type":"blockGroup","content":[{"type":"blockContainer","attrs":{"id":"ref1"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world!"}]}]},{"type":"blockContainer","attrs":{"id":"ref2"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, "},{"type":"mention","attrs":{"user":"John Doe"}},{"type":"text","text":"! "},{"type":"text","marks":[{"type":"bold"}],"text":"How are you doing?"},{"type":"text","text":" "},{"type":"text","marks":[{"type":"textColor","attrs":{"stringValue":"blue"}}],"text":"This text is blue!"}]}]},{"type":"blockContainer","attrs":{"id":"ref3"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world! "},{"type":"text","marks":[{"type":"bold"}],"text":"Bold text. "},{"type":"text","marks":[{"type":"link","attrs":{"href":"https://www.google.com"}}],"text":"Link."}]}]}]}]}",
"R {"type":"doc","content":[{"type":"blockGroup","content":[{"type":"blockContainer","attrs":{"id":"ref1"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world!"}]}]},{"type":"blockContainer","attrs":{"id":"ref2"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, "},{"type":"mention","attrs":{"user":"John Doe"}},{"type":"text","text":"! "},{"type":"text","marks":[{"type":"bold"}],"text":"How are you doing?"},{"type":"text","text":" "},{"type":"text","marks":[{"type":"textColor","attrs":{"stringValue":"blue"}}],"text":"This text is blue!"}]}]},{"type":"blockContainer","attrs":{"id":"ref3"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world! "},{"type":"text","marks":[{"type":"bold"},{"type":"deletion","attrs":{"id":null}}],"text":"Bold text. "},{"type":"text","marks":[{"type":"insertion","attrs":{"id":null}}],"text":"Bold text. "},{"type":"text","marks":[{"type":"link","attrs":{"href":"https://www.google.com"}}],"text":"Link."}]}]}]}]}",
"S {"type":"doc","content":[{"type":"blockGroup","content":[{"type":"blockContainer","attrs":{"id":"ref1"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world!"}]}]},{"type":"blockContainer","attrs":{"id":"ref2"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, "},{"type":"mention","attrs":{"user":"John Doe"}},{"type":"text","text":"! "},{"type":"text","marks":[{"type":"bold"}],"text":"How are you doing?"},{"type":"text","text":" "},{"type":"text","marks":[{"type":"textColor","attrs":{"stringValue":"blue"}}],"text":"This text is blue!"}]}]},{"type":"blockContainer","attrs":{"id":"ref3"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world! "},{"type":"text","marks":[{"type":"bold"},{"type":"deletion","attrs":{"id":null}}],"text":"Bold text. "},{"type":"text","marks":[{"type":"insertion","attrs":{"id":null}}],"text":"Bold text. "},{"type":"text","marks":[{"type":"link","attrs":{"href":"https://www.google.com"}}],"text":"Link."}]}]}]}]}",
- "R {"type":"doc","content":[{"type":"blockGroup","content":[{"type":"blockContainer","attrs":{"id":"ref1"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world!"}]}]},{"type":
|
|
[webkit] › src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:152:7 › Check Keyboard Handlers' Behaviour › Check Backspace preserves nested blocks for empty block:
tests/src/utils/editor.ts#L47
1) [webkit] › src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:152:7 › Check Keyboard Handlers' Behaviour › Check Backspace preserves nested blocks for empty block
Error: expect(string).toMatchSnapshot(expected)
@@ -27,11 +27,11 @@
]
},
{
"type": "blockContainer",
"attrs": {
- "id": "2"
+ "id": "1"
},
"content": [
{
"type": "paragraph",
"attrs": {
Expected: /__w/BlockNote/BlockNote/tests/src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts-snapshots/backspacePreservesNestedBlocksEmpty-json-webkit-linux.json
Received: /__w/BlockNote/BlockNote/tests/test-results/keyboardhandlers-keyboardh-7d281-sted-blocks-for-empty-block-webkit/backspacePreservesNestedBlocksEmpty-json-actual.json
at ../utils/editor.ts:47
45 | // Remove id from docs
46 | const doc = JSON.stringify(await getDoc(page), null, 2);
> 47 | expect(doc).toMatchSnapshot(`${name}.json`);
| ^
48 | }
49 |
at compareDocToSnapshot (/__w/BlockNote/BlockNote/tests/src/utils/editor.ts:47:15)
at /__w/BlockNote/BlockNote/tests/src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:170:5
|
|
Playwright Tests - firefox (2/2)
Docker pull failed with exit code 1, back off 8.399 seconds before retry.
|
|
Playwright Tests - firefox (2/2)
Docker pull failed with exit code 1, back off 1.772 seconds before retry.
|
|
🎭 Playwright Run Summary
42 passed (35.6s)
|
|
🎭 Playwright Run Summary
42 passed (1.0m)
|
|
🎭 Playwright Run Summary
2 skipped
90 passed (1.3m)
|
|
🎭 Playwright Run Summary
15 skipped
77 passed (1.6m)
|
|
🎭 Playwright Run Summary
1 flaky
[webkit] › src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:152:7 › Check Keyboard Handlers' Behaviour › Check Backspace preserves nested blocks for empty block
12 skipped
79 passed (2.4m)
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
blob-report-chromium-1
Expired
|
127 KB |
sha256:6eec2c6c3f7fb15369ebce32e7287077b348983a5c173d54f06664c62675d12a
|
|
|
blob-report-chromium-2
Expired
|
50.8 KB |
sha256:14fb8cb3573093e66b641040cffa56f08e54ca568163098bb4e48933eac754dc
|
|
|
blob-report-firefox-1
Expired
|
114 KB |
sha256:4126ce621a06b2a6ae38ff04e293bd9f9d0a78e075809f8e4f1ddf694d5bf034
|
|
|
blob-report-webkit-1
Expired
|
5.27 MB |
sha256:7bce3ce56ecda3c81d36a8f54ef303a411deb4884e9e034024a9684921e42a45
|
|
|
blob-report-webkit-2
Expired
|
51.9 KB |
sha256:912332920c408a89b28573c3e39464786a99dca9a2b0a86b4d5bbc95873ff6e9
|
|
|
playwright-build
Expired
|
21.5 MB |
sha256:b88465514b30036966f13ea14d16d592de3b2bda2b0c687f7b34a0d0f8088d6c
|
|
|
playwright-report-chromium-1
|
260 KB |
sha256:e42a069f80efc2fddb82fcba6f42c3b3cdd6220207085407955fea70fe18c708
|
|
|
playwright-report-chromium-2
|
208 KB |
sha256:bc239dbbf52d3685c41a5ddb35215fe8bda2103769a2e14491598843401f287f
|
|
|
playwright-report-firefox-1
|
250 KB |
sha256:ef51f684baae2b31acaa5a33d0ffdfa5ebe243d4be81df9acc292ce35cdcf08a
|
|
|
playwright-report-merged
|
5.82 MB |
sha256:a97d18baeb07e7f76dfe114b5a2de1bfa033404064533507ae14b1a1a7cbf22a
|
|
|
playwright-report-webkit-1
|
5.77 MB |
sha256:8a5830b896a3692281fb86bbd59c42cef3ce16d84941ae55ab6b79253c7e93d3
|
|
|
playwright-report-webkit-2
|
209 KB |
sha256:e47bb1524df5a1c485588ac83030efa069df3324858d0789d72fb10a9ca2ac24
|
|