style: apply consistent code formatting across multiple files

deligoez · deligoez · commit ff63f10608bf · 2025-12-14T02:38:44.000+03:00
- Adjusted indentation and spacing for better readability in `PlaceholderModifier.php`, `ProductionAttributeModifier.php`, and test files.
- Standardized inline conditional structures for improved clarity.
- Reorganized import statements for multiple files to maintain consistent positioning.
diff --git a/src/Placeholder/PlaceholderModifier.php b/src/Placeholder/PlaceholderModifier.php
@@ -184,8 +184,7 @@ private function processTestFile(string $filePath, array $actions, bool $dryRun)
                 $result = $this->replacePestPlaceholder($code, $placeholderId, array_values($productionMethods));
             } elseif ($useSeeTag) {
                 $result = $this->replacePhpUnitPlaceholderWithSeeTag($code, $placeholderId, array_values($productionMethods));
-            }
-            else {
+            } else {
                 $result = $this->replacePhpUnitPlaceholder($code, $placeholderId, array_values($productionMethods));
             }
 
diff --git a/src/Placeholder/PlaceholderRegistry.php b/src/Placeholder/PlaceholderRegistry.php
@@ -22,9 +22,7 @@ final class PlaceholderRegistry
      */
     private const PLACEHOLDER_PATTERN = '/^@@?[A-Za-z][A-Za-z0-9_-]*$/';
 
-    /**
-     * Regex pattern for @see tag placeholders (@@prefix).
-     */
+    /** Regex pattern for @see tag placeholders (@@prefix). */
     private const SEE_TAG_PLACEHOLDER_PATTERN = '/^@@[A-Za-z][A-Za-z0-9_-]*$/';
 
     /**
diff --git a/src/Sync/Discovery/ProductionFileDiscovery.php b/src/Sync/Discovery/ProductionFileDiscovery.php
@@ -4,8 +4,8 @@
 
 namespace TestFlowLabs\TestLink\Sync\Discovery;
 
-use Composer\Autoload\ClassLoader;
 use ReflectionClass;
+use Composer\Autoload\ClassLoader;
 use TestFlowLabs\TestLink\Sync\Exception\ProductionFileNotFoundException;
 
 /**
diff --git a/src/Sync/Modifier/ProductionAttributeModifier.php b/src/Sync/Modifier/ProductionAttributeModifier.php
@@ -55,8 +55,8 @@ public function apply(array $actions): SyncResult
                 $newCode = $this->injectTestedBy($code, $action);
 
                 if ($newCode !== $code) {
-                    $code         = $newCode;
-                    $modified     = true;
+                    $code           = $newCode;
+                    $modified       = true;
                     $addedMethods[] = $action->testIdentifier;
                 }
             }
@@ -184,10 +184,8 @@ private function hasTestedByAttribute(array $lines, int $methodLine, string $tes
         for ($i = max(0, $methodLine - 20); $i < $methodLine; $i++) {
             $line = $lines[$i];
 
-            if (preg_match('/#\[TestedBy\s*\(/', $line) && str_contains($line, "{$testClass}::class")) {
-                if ($testMethod === null || str_contains($line, "'{$testMethod}'")) {
-                    return true;
-                }
+            if (preg_match('/#\[TestedBy\s*\(/', $line) && str_contains($line, "{$testClass}::class") && ($testMethod === null || str_contains($line, "'{$testMethod}'"))) {
+                return true;
             }
         }
 
diff --git a/src/Sync/SyncCommand.php b/src/Sync/SyncCommand.php
@@ -14,9 +14,9 @@
 use TestFlowLabs\TestLink\Sync\Discovery\TestFileDiscovery;
 use TestFlowLabs\TestLink\Sync\Modifier\ProductionFileModifier;
 use TestFlowLabs\TestLink\Sync\Discovery\ProductionFileDiscovery;
-use TestFlowLabs\TestLink\Sync\Modifier\ProductionAttributeModifier;
 use TestFlowLabs\TestLink\Sync\Exception\TestCaseNotFoundException;
 use TestFlowLabs\TestLink\Sync\Exception\TestFileNotFoundException;
+use TestFlowLabs\TestLink\Sync\Modifier\ProductionAttributeModifier;
 use TestFlowLabs\TestLink\Sync\Exception\ProductionFileNotFoundException;
 
 /**
diff --git a/tests/Unit/Placeholder/PlaceholderModifierTest.php b/tests/Unit/Placeholder/PlaceholderModifierTest.php
@@ -410,17 +410,17 @@ public function create(): void {}
                 $content = file_get_contents($prodFile);
 
                 return [
-                    'has_see_tag'       => str_contains($content, '@see'),
-                    'has_fqcn'          => str_contains($content, '\\Tests\\Unit\\SeeTagServiceTest::testCreate'),
-                    'no_testedby'       => !str_contains($content, '#[TestedBy'),
-                    'no_placeholder'    => !str_contains($content, '@@A'),
+                    'has_see_tag'    => str_contains($content, '@see'),
+                    'has_fqcn'       => str_contains($content, '\\Tests\\Unit\\SeeTagServiceTest::testCreate'),
+                    'no_testedby'    => !str_contains($content, '#[TestedBy'),
+                    'no_placeholder' => !str_contains($content, '@@A'),
                 ];
             })
             ->toMatchArray([
-                'has_see_tag'       => true,
-                'has_fqcn'          => true,
-                'no_testedby'       => true,
-                'no_placeholder'    => true,
+                'has_see_tag'    => true,
+                'has_fqcn'       => true,
+                'no_testedby'    => true,
+                'no_placeholder' => true,
             ]);
 
         it('replaces @@prefix placeholder with @see tag in PHPUnit test')
@@ -452,17 +452,17 @@ public function testCreate(): void {}
                 $content = file_get_contents($testFile);
 
                 return [
-                    'has_see_tag'      => str_contains($content, '@see'),
-                    'has_fqcn'         => str_contains($content, '\\App\\Services\\UserService::create'),
-                    'no_attribute'     => !str_contains($content, '#[LinksAndCovers'),
-                    'no_placeholder'   => !str_contains($content, '@@A'),
+                    'has_see_tag'    => str_contains($content, '@see'),
+                    'has_fqcn'       => str_contains($content, '\\App\\Services\\UserService::create'),
+                    'no_attribute'   => !str_contains($content, '#[LinksAndCovers'),
+                    'no_placeholder' => !str_contains($content, '@@A'),
                 ];
             })
             ->toMatchArray([
-                'has_see_tag'      => true,
-                'has_fqcn'         => true,
-                'no_attribute'     => true,
-                'no_placeholder'   => true,
+                'has_see_tag'    => true,
+                'has_fqcn'       => true,
+                'no_attribute'   => true,
+                'no_placeholder' => true,
             ]);
 
         it('uses FQCN with leading backslash in @see tags')
@@ -546,7 +546,7 @@ public function method(): void {}
         it('does not modify Pest test files for @@prefix (unsupported)')
             ->linksAndCovers(PlaceholderModifier::class.'::apply')
             ->expect(function () {
-                $testFile = $this->tempDir.'/PestSeeTest.php';
+                $testFile        = $this->tempDir.'/PestSeeTest.php';
                 $originalContent = <<<'PHP'
 <?php
 test('pest test', function () {
diff --git a/tests/Unit/Placeholder/PlaceholderResolverTest.php b/tests/Unit/Placeholder/PlaceholderResolverTest.php
@@ -159,18 +159,18 @@
                 $result   = $resolver->resolve($registry);
 
                 return [
-                    'has_errors'        => $result->hasErrors(),
-                    'has_actions'       => $result->hasActions(),
-                    'error_contains_at' => str_contains($result->errors[0], '@@A'),
-                    'error_mentions_see' => str_contains($result->errors[0], '@see'),
+                    'has_errors'          => $result->hasErrors(),
+                    'has_actions'         => $result->hasActions(),
+                    'error_contains_at'   => str_contains($result->errors[0], '@@A'),
+                    'error_mentions_see'  => str_contains($result->errors[0], '@see'),
                     'error_mentions_pest' => str_contains($result->errors[0], 'Pest'),
                 ];
             })
             ->toMatchArray([
-                'has_errors'        => true,
-                'has_actions'       => false,
-                'error_contains_at' => true,
-                'error_mentions_see' => true,
+                'has_errors'          => true,
+                'has_actions'         => false,
+                'error_contains_at'   => true,
+                'error_mentions_see'  => true,
                 'error_mentions_pest' => true,
             ]);
 
diff --git a/tests/Unit/Scanner/PestLinkScannerTest.php b/tests/Unit/Scanner/PestLinkScannerTest.php
@@ -7,8 +7,8 @@
 
 describe('PestLinkScanner', function (): void {
     beforeEach(function (): void {
-        $this->scanner  = new PestLinkScanner();
-        $this->testDir  = sys_get_temp_dir().'/testlink-pest-scanner-'.uniqid();
+        $this->scanner = new PestLinkScanner();
+        $this->testDir = sys_get_temp_dir().'/testlink-pest-scanner-'.uniqid();
 
         @mkdir($this->testDir.'/tests/Unit', 0777, true);
     });

Original file line number	Diff line number	Diff line change
`@@ -184,8 +184,7 @@ private function processTestFile(string $filePath, array $actions, bool $dryRun)`
`184`	`184`	`$result = $this->replacePestPlaceholder($code, $placeholderId, array_values($productionMethods));`
`185`	`185`	`} elseif ($useSeeTag) {`
`186`	`186`	`$result = $this->replacePhpUnitPlaceholderWithSeeTag($code, $placeholderId, array_values($productionMethods));`
`187`		`- }`
`188`		`- else {`
	`187`	`+ } else {`
`189`	`188`	`$result = $this->replacePhpUnitPlaceholder($code, $placeholderId, array_values($productionMethods));`
`190`	`189`	`}`
`191`	`190`
Original file line number	Diff line number	Diff line change
`@@ -55,8 +55,8 @@ public function apply(array $actions): SyncResult`
`55`	`55`	`$newCode = $this->injectTestedBy($code, $action);`
`56`	`56`
`57`	`57`	`if ($newCode !== $code) {`
`58`		`- $code = $newCode;`
`59`		`- $modified = true;`
	`58`	`+ $code = $newCode;`
	`59`	`+ $modified = true;`
`60`	`60`	`$addedMethods[] = $action->testIdentifier;`
`61`	`61`	`}`
`62`	`62`	`}`
`@@ -184,10 +184,8 @@ private function hasTestedByAttribute(array $lines, int $methodLine, string $tes`
`184`	`184`	`for ($i = max(0, $methodLine - 20); $i < $methodLine; $i++) {`
`185`	`185`	`$line = $lines[$i];`
`186`	`186`
`187`		`- if (preg_match('/#\[TestedBy\s*\(/', $line) && str_contains($line, "{$testClass}::class")) {`
`188`		`- if ($testMethod === null \|\| str_contains($line, "'{$testMethod}'")) {`
`189`		`- return true;`
`190`		`- }`
	`187`	`+ if (preg_match('/#\[TestedBy\s*\(/', $line) && str_contains($line, "{$testClass}::class") && ($testMethod === null \|\| str_contains($line, "'{$testMethod}'"))) {`
	`188`	`+ return true;`
`191`	`189`	`}`
`192`	`190`	`}`
`193`	`191`