修复ModelBinder的奇妙BUG

Author: Surbowl

Routine/Routine.APi/Controllers/CompanyCollectionsController.cs

@@ -25,7 +25,7 @@ public CompanyCollectionsController(IMapper mapper, ICompanyRepository companyRe
                                     throw new ArgumentNullException(nameof(companyRepository));
         }
 
-        [HttpGet("({ids})",Name =nameof(GetCompanyCollection))]
+        [HttpGet("({ids})", Name = nameof(GetCompanyCollection))]
         public async Task<IActionResult> GetCompanyCollection([FromRoute]
                                                               [ModelBinder(BinderType = typeof(ArrayModelBinder))]
                                                               IEnumerable<Guid> ids)
@@ -36,11 +36,10 @@ public async Task<IActionResult> GetCompanyCollection([FromRoute]
             }
             var entities = await _companyRepository.GetCompaniesAsync(ids);
 
-            //这个写法有 BUG，ids.Count() 返回的居然是 Query 字符串长度
-            //if (ids.Count() != entities.Count())
-            //{
-            //    return NotFound();
-            //}
+            if (ids.Count() != entities.Count())
+            {
+                return NotFound();
+            }
 
             var dtosToReturn = _mapper.Map<IEnumerable<CompanyDto>>(entities);
             return Ok(dtosToReturn);

Routine/Routine.APi/Helpers/ArrayModelBinder.cs

@@ -33,7 +33,7 @@ public Task BindModelAsync(ModelBindingContext bindingContext)
             var converter = TypeDescriptor.GetConverter(elementType);
             var values = value.Split(new[] { "," }, StringSplitOptions.RemoveEmptyEntries)
                                 .Select(x => converter.ConvertFromString(x.Trim())).ToArray();
-            var typedValues = Array.CreateInstance(elementType, value.Length);
+            var typedValues = Array.CreateInstance(elementType, values.Length);
             values.CopyTo(typedValues, 0);
             bindingContext.Model = typedValues;
             bindingContext.Result = ModelBindingResult.Success(bindingContext.Model);