add unit test coverage for new config defaults and outputs

Signed-off-by: lelia <2418071+lelia@users.noreply.github.com>

Author: lelia

tests/unit/test_cli_config.py

@@ -81,4 +81,30 @@ def test_workspace_is_independent_of_workspace_name(self):
             "--workspace-name", "monorepo-suffix",
         ])
         assert config.workspace == "my-workspace"
-        assert config.workspace_name == "monorepo-suffix"
+        assert config.workspace_name == "monorepo-suffix"
+
+    def test_legal_flag_sets_default_artifact_files(self):
+        config = CliConfig.from_args(["--api-token", "test", "--legal"])
+        assert config.legal is True
+        assert config.generate_license is True
+        assert config.json_file == "socket-report.json"
+        assert config.summary_file == "socket-summary.txt"
+        assert config.report_link_file == "socket-report-link.txt"
+        assert config.sbom_file == "socket-sbom.json"
+        assert config.license_file_name == "socket-license.json"
+
+    def test_legal_flag_preserves_explicit_file_paths(self):
+        config = CliConfig.from_args([
+            "--api-token", "test",
+            "--legal",
+            "--json-file", "custom-report.json",
+            "--summary-file", "custom-summary.txt",
+            "--report-link-file", "custom-link.txt",
+            "--sbom-file", "custom-sbom.json",
+            "--license-file-name", "custom-license.json",
+        ])
+        assert config.json_file == "custom-report.json"
+        assert config.summary_file == "custom-summary.txt"
+        assert config.report_link_file == "custom-link.txt"
+        assert config.sbom_file == "custom-sbom.json"
+        assert config.license_file_name == "custom-license.json"

tests/unit/test_output.py

@@ -123,6 +123,111 @@ def test_sbom_file_saving(self, handler, tmp_path):
         handler.save_sbom_file(diff, str(sbom_path))
         assert sbom_path.exists()
 
+    def test_json_file_saving(self, tmp_path):
+        from socketsecurity.config import CliConfig
+        from unittest.mock import Mock
+
+        json_path = tmp_path / "report.json"
+
+        config = Mock(spec=CliConfig)
+        config.disable_blocking = False
+        config.strict_blocking = False
+        config.json_file = str(json_path)
+        config.summary_file = None
+        config.report_link_file = None
+        config.sbom_file = None
+        config.legal = True
+        config.repo = "owner/repo"
+        config.branch = "main"
+        config.commit_sha = "abc123"
+        config.enable_json = False
+        config.enable_sarif = False
+        config.enable_gitlab_security = False
+        config.enable_debug = False
+
+        handler = OutputHandler(config, Mock())
+
+        diff = Diff()
+        diff.id = "scan-123"
+        diff.diff_url = "https://socket.dev/diff/123"
+        diff.report_url = "https://socket.dev/report/123"
+        diff.new_alerts = [
+            Issue(
+                title="Test",
+                severity="high",
+                description="desc",
+                error=True,
+                key="test-key",
+                type="vulnerability",
+                pkg_type="npm",
+                pkg_name="test-package",
+                pkg_version="1.0.0",
+                purl="pkg:npm/test-package@1.0.0",
+                url="https://socket.dev/npm/package/test-package/alerts/1.0.0",
+            )
+        ]
+
+        handler.save_json_file(diff, str(json_path))
+
+        saved = json.loads(json_path.read_text())
+        assert saved["full_scan_id"] == "scan-123"
+        assert saved["report_url"] == "https://socket.dev/report/123"
+        assert saved["repo"] == "owner/repo"
+        assert saved["branch"] == "main"
+        assert saved["commit_sha"] == "abc123"
+        assert saved["legal_mode"] is True
+
+    def test_summary_and_report_link_files_are_written(self, tmp_path):
+        from socketsecurity.config import CliConfig
+        from unittest.mock import Mock
+
+        summary_path = tmp_path / "summary.txt"
+        report_link_path = tmp_path / "report-link.txt"
+
+        config = Mock(spec=CliConfig)
+        config.disable_blocking = False
+        config.strict_blocking = False
+        config.json_file = None
+        config.summary_file = str(summary_path)
+        config.report_link_file = str(report_link_path)
+        config.sbom_file = None
+        config.legal = False
+        config.repo = None
+        config.branch = ""
+        config.commit_sha = ""
+        config.enable_json = False
+        config.enable_sarif = False
+        config.enable_gitlab_security = False
+        config.enable_debug = False
+
+        handler = OutputHandler(config, Mock())
+
+        diff = Diff()
+        diff.id = "scan-123"
+        diff.diff_url = "https://socket.dev/diff/123"
+        diff.report_url = "https://socket.dev/report/123"
+        diff.new_alerts = [
+            Issue(
+                title="Test",
+                severity="high",
+                description="desc",
+                error=True,
+                key="test-key",
+                type="vulnerability",
+                pkg_type="npm",
+                pkg_name="test-package",
+                pkg_version="1.0.0",
+                purl="pkg:npm/test-package@1.0.0",
+                url="https://socket.dev/npm/package/test-package/alerts/1.0.0",
+            )
+        ]
+
+        handler.save_summary_file(diff, str(summary_path))
+        handler.save_report_link_file(diff, str(report_link_path))
+
+        assert "Security issues detected by Socket Security:" in summary_path.read_text()
+        assert report_link_path.read_text().strip() == "https://socket.dev/report/123"
+
     def test_report_pass_with_strict_blocking_new_alerts(self):
         """Test that strict-blocking fails on new blocking alerts"""
         from socketsecurity.config import CliConfig